Rolling back the use of useFetchStreams, which has lead to hanging queries. #7729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e536dd4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ehsannas
requested changes
Oct 26, 2023
packages/firestore/src/platform/browser/webchannel_connection.ts
Outdated
Show resolved
Hide resolved
packages/firestore/src/platform/browser/webchannel_connection.ts
Outdated
Show resolved
Hide resolved
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (133,688 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
ehsannas
approved these changes
Oct 26, 2023
hsubox76
approved these changes
Oct 26, 2023
Merged
prameshj
pushed a commit
that referenced
this pull request
Nov 13, 2023
…eries. (#7729) * Rolling back the use of useFetchStreams, which has lead to hanging queries.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolling back the use of useFetchStreams, which has lead to hanging queries.
Writing additional automated tests for this is non-trivial. This change has been tested locally using
yarn linkagainst a reproduction project. This change can be pushed alone, or it can wait for automated tests to be written.This is the original change we're rolling back: https://github.com/firebase/firebase-js-sdk/pull/7569/files#diff-a0dc4840c5dc14c6bd4f1a172930675ddde606430fbc23bc613aca0cbd6d031d