Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment changes for OSS #7778

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Comment changes for OSS #7778

merged 6 commits into from
Nov 14, 2023

Conversation

DellaBitta
Copy link
Contributor

Discussion

Updating license headers and contribution guide for a better open source experience.

Testing

N/A

API Changes

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ec291e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 13, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (bebecda) and merge commit (27005e1).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/w8mBQUdepl.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 13, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (bebecda) and merge commit (27005e1).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BsVe7iVg8d.html

@DellaBitta DellaBitta marked this pull request as ready for review November 13, 2023 20:44
MarkDuckworth
MarkDuckworth approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prameshj
prameshj approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for auth.

@DellaBitta DellaBitta merged commit ebc694a into master Nov 14, 2023
41 checks passed
@DellaBitta DellaBitta deleted the ddb-oss-prep branch November 14, 2023 20:24
@firebase firebase locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prameshj prameshj prameshj approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@erikeldridge erikeldridge Awaiting requested review from erikeldridge

@avolkovi avolkovi Awaiting requested review from avolkovi

@yoyomyo yoyomyo Awaiting requested review from yoyomyo

@lisajian lisajian Awaiting requested review from lisajian

@renkelvin renkelvin Awaiting requested review from renkelvin

@sam-gc sam-gc Awaiting requested review from sam-gc

@zwu52 zwu52 Awaiting requested review from zwu52

@maneesht maneesht Awaiting requested review from maneesht

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DellaBitta @google-oss-bot @MarkDuckworth @hsubox76 @prameshj