Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isSafari() throwing on React Native (fixes #7962) #7963

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Fix isSafari() throwing on React Native (fixes #7962) #7963

merged 5 commits into from
Jan 19, 2024

Conversation

Yonom
Copy link
Contributor

@Yonom Yonom commented Jan 19, 2024

In #7929 some logic was added to Firestore to check for the browser being Safari. This new check for isSafari() unexpectedly threw an exception in React Native. This PR fixes the exception by explicitly checking for an object not being undefined before using it.

Fixes #7962

@Yonom Yonom requested a review from a team as a code owner January 19, 2024 14:10
Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: d94a69b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@firebase/util Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-check-compat Patch
@firebase/app-check Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/auth-compat Patch
@firebase/auth Patch
@firebase/component Patch
@firebase/database-compat Patch
@firebase/database-types Patch
@firebase/database Patch
firebase Patch
@firebase/firestore-compat Patch
@firebase/firestore Patch
@firebase/functions-compat Patch
@firebase/functions Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch
@firebase/storage-compat Patch
@firebase/storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Yonom Yonom requested review from a team as code owners January 19, 2024 14:12
packages/util/src/environment.ts Outdated Show resolved Hide resolved
@dconeybe
Copy link
Contributor

Looks like GitHub Actions fails miserably when run in a PR from an external contributor. I've opened #7965 to run them under my name. We can use those results to gate this PR's merge then just force-merge this one.

Co-authored-by: dconeybe <dconeybe@google.com>
@DellaBitta DellaBitta merged commit 434f841 into firebase:master Jan 19, 2024
29 of 32 checks passed
@Yonom Yonom deleted the patch-1 branch January 20, 2024 11:35
@google-oss-bot google-oss-bot mentioned this pull request Jan 30, 2024
@firebase firebase locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firestore crashes after 10.7.1 -> 10.7.2 update in Expo/React Native
3 participants