-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix isSafari() throwing on React Native (fixes #7962) #7963
Conversation
🦋 Changeset detectedLatest commit: d94a69b The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like GitHub Actions fails miserably when run in a PR from an external contributor. I've opened #7965 to run them under my name. We can use those results to gate this PR's merge then just force-merge this one. |
Co-authored-by: dconeybe <dconeybe@google.com>
In #7929 some logic was added to Firestore to check for the browser being Safari. This new check for
isSafari()
unexpectedly threw an exception in React Native. This PR fixes the exception by explicitly checking for an object not beingundefined
before using it.Fixes #7962