Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back using xmlhttprequest for bidi-streams #8197

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Apr 22, 2024

Go back using xmlhttprequest for bidi-streams, as fetch streams seem to be having connection issue.

@wu-hui wu-hui requested review from a team as code owners April 22, 2024 18:00
Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 97f457a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wu-hui wu-hui requested a review from a team as a code owner April 22, 2024 18:07
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2024

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (03069bb)Merge (402b93d)Diff
    browser377 kB377 kB+47 B (+0.0%)
    esm5362 kB362 kB+47 B (+0.0%)
    module377 kB377 kB+47 B (+0.0%)
    react-native377 kB377 kB+47 B (+0.0%)
  • bundle

    TypeBase (03069bb)Merge (402b93d)Diff
    firestore (CSI Auto Indexing Disable and Delete)269 kB269 kB+17 B (+0.0%)
    firestore (CSI Auto Indexing Enable)269 kB269 kB+17 B (+0.0%)
    firestore (Persistence)303 kB303 kB+17 B (+0.0%)
    firestore (Query Cursors)241 kB241 kB+17 B (+0.0%)
    firestore (Query)238 kB238 kB+17 B (+0.0%)
    firestore (Read data once)226 kB226 kB+17 B (+0.0%)
    firestore (Read Write w Persistence)323 kB323 kB+17 B (+0.0%)
    firestore (Realtime updates)229 kB229 kB+17 B (+0.0%)
    firestore (Transaction)205 kB205 kB+17 B (+0.0%)
    firestore (Write data)205 kB205 kB+17 B (+0.0%)
  • firebase

    TypeBase (03069bb)Merge (402b93d)Diff
    firebase-compat.js786 kB786 kB+13 B (+0.0%)
    firebase-firestore-compat.js342 kB342 kB+13 B (+0.0%)
    firebase-firestore.js436 kB436 kB-15 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wWnbbfLz3A.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2024

Size Analysis Report 1

This report is too large (136,860 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xgfRtQcad4.html

Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want to hold this until the release staging deadline, while we investigate alternative fixes.

@wu-hui wu-hui merged commit e1a7764 into master Apr 24, 2024
44 checks passed
@wu-hui wu-hui deleted the wuandy/XmlHttpAgain branch April 24, 2024 13:23
@google-oss-bot google-oss-bot mentioned this pull request Apr 24, 2024
@firebase firebase locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants