Generate dts rollups for auth webextension and cordova #8251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlarocque
requested review from
a team,
lisajian,
Xiaoshouzi-gh and
sam-gc
as code owners
🦋 Changeset detectedLatest commit: a4efa7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (3883133) and merge commit (957db22).Test Logs |
hsubox76
reviewed
May 22, 2024
There was a problem hiding this comment.
We also have to get lines 42 and 46 in this file. I think that Node ESM uses them.
hsubox76
reviewed
May 22, 2024
dlarocque
force-pushed
the
dlarocque/auth-dts-rollup
branch
from
dda3035 to
491e4ed
Compare
dlarocque
force-pushed
the
dlarocque/auth-dts-rollup
branch
from
491e4ed to
138ea2f
Compare
hsubox76
approved these changes
May 22, 2024
packages/auth/package.json
Outdated
| @@ -39,11 +39,11 @@ | |||
| "default": "./dist/esm2017/index.js" | |||
| }, | |||
| "./cordova": { | |||
| "types": "./dist/cordova/index.cordova.d.ts", | |||
| "types": "./dist/cordova/auth-cordova.d.ts", | |||
packages/auth/package.json
Outdated
| "default": "./dist/cordova/index.js" | ||
| }, | ||
| "./web-extension": { | ||
| "types:": "./dist/web-extension-esm2017/index.web-extension.d.ts", | ||
| "types:": "./dist/web-extension-esm2017/auth-web-extension.d.ts", |
There was a problem hiding this comment.
auth-web-extension-public
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8222
auth web-extension and cordova packages had typings that were not rolled up by dts, which caused some compilation errors to arise in the typings files.
The API extractor tool does not work with package names with more than one
/, so we have to change the package names for these from@firebase/auth-web-extension->@firebase/auth-web-extension, and@firebase/auth/cordova->@firebase/auth-cordova. This does not affect the way we import these packages, since that's done through the firebase package, and the typings are resolved based on the directory name (e.g../auth/cordova) rather than the package name.Note: There are a lot of warnings coming from the API extractor because it is not able to resolve
@link's, since these packages don't actually export what their entrypoints export. I currently don't have any ideas on how to fix this.Example:
firebase-js-sdk/packages/auth/dist/web-extension-esm2017/index.web-extension.d.ts:3311:5 - (ae-unresolved-link) The @link reference could not be resolved: The package "@firebase/auth-web-extension" does not have an export "ProviderId"