Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex GA] Add new endpoint and error message. #8497

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

hsubox76
Copy link
Contributor

See b/365756200 (internal).

Endpoint will change for GA. Add a special error message for if the api is not enabled (for users that were using the old endpoint) that guides users to enable it.

Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: 0c540bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2024

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (09ba48f)Merge (8f8e288)Diff
    browser28.0 kB28.9 kB+907 B (+3.2%)
    main28.8 kB29.7 kB+907 B (+3.1%)
    module28.0 kB28.9 kB+907 B (+3.2%)
  • firebase

    TypeBase (09ba48f)Merge (8f8e288)Diff
    firebase-vertexai.js21.6 kB22.4 kB+806 B (+3.7%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5wYCwix9lN.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2024

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • ChatSession

      Size

      TypeBase (09ba48f)Merge (8f8e288)Diff
      size14.1 kB14.9 kB+809 B (+5.7%)
      size-with-ext-deps32.5 kB33.3 kB+810 B (+2.5%)
    • GenerativeModel

      Size

      TypeBase (09ba48f)Merge (8f8e288)Diff
      size16.6 kB17.4 kB+809 B (+4.9%)
      size-with-ext-deps35.0 kB35.9 kB+810 B (+2.3%)
    • getGenerativeModel

      Size

      TypeBase (09ba48f)Merge (8f8e288)Diff
      size16.7 kB17.5 kB+809 B (+4.8%)
      size-with-ext-deps35.2 kB36.0 kB+810 B (+2.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5DmmsoGaVT.html

@hsubox76 hsubox76 changed the title Add new endpoint and error message. [Vertex GA] Add new endpoint and error message. Sep 23, 2024
@hsubox76 hsubox76 marked this pull request as ready for review September 23, 2024 18:08
@hsubox76 hsubox76 requested a review from a team as a code owner September 23, 2024 18:08
@hsubox76 hsubox76 added this to the Vertex GA milestone Sep 23, 2024
@hsubox76 hsubox76 merged commit 245e65e into v11 Sep 24, 2024
39 of 40 checks passed
@hsubox76 hsubox76 deleted the ch-vertex-endpoint branch September 24, 2024 22:07
hsubox76 added a commit that referenced this pull request Oct 17, 2024
* Add node engines fields specifying a minimum of 18 (#8457)

* Make memory lru gc the default (#8110)

* Make memory lru gc the default

* undo yarn.lock

* Make memory lru gc the default

* Fix tests

* V11 release removal of node-fetch and undici dependencies (#8492)

Our v11 release will require node 18+. Since fetch has been introduced in these node versions, we can remove our dependency on third party fetch implementations.

This change removes our usage of fetch variants undici and node-fetch for our node target builds and our CI tools.

* V11 - Remove functions node bundle (#8507)

With the removal of fetch we no long need to create a node bundle for functions. Instead the sourcebase may become isomorphic, so long as we remove the older node sources. And that's what the PR does!

* Initial changes for Vertex GA packaging (#8498)

* [Vertex GA] Rewrite Schema (#8479)

* [Vertex GA] Add new endpoint and error message. (#8497)

* [Vertex GA] Miscellaneous breaking changes for Vertex GA (#8514)

* Remove ES5 Support (#8509)

* Emit a module package file for functions ESM builds (#8517)

* Update API_NOT_ENABLED error for Vertex (#8549)

* Upgrade cjs bundles for storage and performance (#8557)

These should have been part of the bigger PR, but I missed these.

* Rollup JS files with rollup-typescript-plugin (#8503)

The rollup-typescript-plugin does not transpile JS files using the TS
compiler by default. This means that external dependencies that provide
JS bundles will not be transpiled to the target ES version specified in
the TypeScript config used by the plugin.

This resulted in one of our dependencies (https://github.com/jakearchibald/idb)
being included in the CDN bundles without being transpiled to
ES5 (the target ES version). Since this dependencies bundle uses
ES2018 syntax (object spread operator `{ ...x }`), this upgraded our CDN
bundles' minimum ES version requirement to ES2018 which isn't compatible with older browser versions.
To see the ES2018 syntax in one of the CDN bundles, see
https://www.gstatic.com/firebasejs/10.13.1/firebase-app.js and search for `...oldTraps`.

* Fix tsc errors in vertex tests (#8562)

* Make SafetySettings.method optional (#8567)

* Make SafetySettings.method optional

* Update API reports

---------

Co-authored-by: hsubox76 <hsubox76@users.noreply.github.com>

* [Vertex GA] Regenerate docs after Vertex GA changes (#8505)

* Close emulator file after download is complete (#8572)

* close file

* Add test:ci to end of test command in CI

* revert workflow file changes

* format

* rename vertexai package reference in a changeset (#8573)

* Missed one doc change from a PR (#8575)

* Overwrite undefined candidate index (#8577)

* Overwrite undefined candidate index

* Fix index overwrite condition to only be true when index is not a property

* Upgrade Vertex Mock Responses to V5 (#8579)

* Upgrade to mock responses v4

* Upgrade from v4 to v5 mock responses

---------

Co-authored-by: wu-hui <53845758+wu-hui@users.noreply.github.com>
Co-authored-by: DellaBitta <DellaBitta@users.noreply.github.com>
Co-authored-by: Daniel La Rocque <dlarocque@google.com>
Co-authored-by: hsubox76 <hsubox76@users.noreply.github.com>
@firebase firebase locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants