Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo-scripts test case failing due to incorrect name #8508

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

dlarocque
Copy link
Contributor

The tests in repo-scripts/prune-dts read all *.input.d.ts and try to read the corresponding *.output.d.ts files with the same name.
This causes a test case to fail because there is a file named resolves-generics-through-inheritance.input.d.ts, but the corresponding output file is incorrectly named resolves-generics-through-inheritence.index.d.ts (inheritence, not inheritance), so there's an error when we try to read the file:

1 failing

  1) Prune DTS
       resolves generics through inheritance:
     Error: ENOENT: no such file or directory, open '/Users/dlarocque/workspace/firebase-js-sdk/repo-scripts/prune-dts/tests/resolves-generics-through-inheritance.output.d.ts'

@dlarocque dlarocque requested a review from a team as a code owner September 20, 2024 17:39
Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: 33ed6d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@dlarocque dlarocque merged commit 5f3ef9d into main Oct 2, 2024
34 of 35 checks passed
@dlarocque dlarocque deleted the dl/fix-repo-scripts-test branch October 2, 2024 16:13
@firebase firebase locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants