Skip to content

Commit

Permalink
Fix service_location not passed to dataconnect binary. (#7217)
Browse files Browse the repository at this point in the history
* Fix service_location not passed to dataconnect binary.

* Update CHANGELOG.md
  • Loading branch information
yuchenshi authored May 24, 2024
1 parent 5463aad commit 45a5718
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Fixes an issue where dataconnect:sql:migrate still prompts for confirmation even with `--force`. (#7208)
- Update to Firebase Data Connect Emulator version 1.1.18 which contains code generation bug fixes, surfacing schema migration errors when a diff remains after migration, and a fix to allow the local connection string to be empty at startup.
- Fixes an issue where the dataconnect emulator listens on all addresses by default instead of just localhost (#7211).
- Fixes Data Connect generated SDK sometimes using the wrong location (GCP region) (#7217).
8 changes: 7 additions & 1 deletion src/emulator/downloadableEmulators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,13 @@ const Commands: { [s in DownloadableEmulators]: DownloadableEmulatorCommand } =
dataconnect: {
binary: getExecPath(Emulators.DATACONNECT),
args: ["dev"],
optionalArgs: ["listen", "config_dir", "local_connection_string", "project_id"],
optionalArgs: [
"listen",
"config_dir",
"local_connection_string",
"project_id",
"service_location",
],
joinArgs: true,
shell: true,
},
Expand Down

0 comments on commit 45a5718

Please sign in to comment.