Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set environment variable necessary to be a custom events source #5078

Merged
merged 4 commits into from
Oct 28, 2022

Conversation

inlined
Copy link
Member

@inlined inlined commented Oct 6, 2022

The admin SDK does/will read the CloudEvent source field from an environment variable so that firebase can inject an experiment ID, function ID, or service ID rather than requiring customers to encode their deployment name in their codebase (not even possible for extensions).

@inlined inlined requested a review from taeold October 6, 2022 19:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 56.19% // Head: 56.17% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (834a50f) compared to base (74c1b19).
Patch coverage: 18.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5078      +/-   ##
==========================================
- Coverage   56.19%   56.17%   -0.02%     
==========================================
  Files         308      308              
  Lines       20737    20752      +15     
  Branches     4199     4206       +7     
==========================================
+ Hits        11653    11658       +5     
- Misses       8071     8081      +10     
  Partials     1013     1013              
Impacted Files Coverage Δ
src/emulator/functionsEmulatorShared.ts 42.30% <14.28%> (-1.13%) ⬇️
src/deploy/functions/prepare.ts 29.64% <22.22%> (-0.20%) ⬇️
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Does emulator need similar treatment?

@inlined
Copy link
Member Author

inlined commented Oct 6, 2022

Yes it does. Where would I put that?

@inlined inlined enabled auto-merge (squash) October 28, 2022 19:57
@inlined inlined merged commit 818ea6c into master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants