Assign emulator ports and resolve hostnames upfront. #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
commented
Oct 7, 2022
| // Listening on multiple addresses to maximize the chance of discovery. | ||
| hub: false, | ||
|
|
||
| // TODO: Modify the following emulators to listen on multiple addresses. |
There was a problem hiding this comment.
Q: Do want this to happen in the same release or later?
Codecov ReportBase: 55.97% // Head: 56.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5083 +/- ##
==========================================
+ Coverage 55.97% 56.04% +0.06%
==========================================
Files 306 307 +1
Lines 20484 20629 +145
Branches 4135 4164 +29
==========================================
+ Hits 11466 11561 +95
- Misses 8036 8068 +32
- Partials 982 1000 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bkendall
approved these changes
Oct 7, 2022
christhompsongoogle
approved these changes
Oct 7, 2022
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR explicitly resolves hostnames like
localhostto IP addresses like127.0.0.1,::1before listening for each emulator and assigns all the ports all at once early in the process.It also modifies the Emulator Hub to listen on as many addresses as it can to increase the chance of successful discovery (no matter the client is v4- or v6-only). If we like what we're seeing here, we can apply this to most other Node.js-based emulators (see comments inline).
The new test process use the more reliable net Socket instead of
tcp-port-used. There's only one instance of it left to test for port closed (occupied by emulator), and I wonder if we still need it. (Also, the new test process is more or less similar toportfinderand maybe we can remove the dependency of it one day, after we update all the other usages.)Since the ports are all allocated early, this may fix the frameworks autoinit integration.
Scenarios Tested
Manually started the emulators, observed what ports are allocated with
--debug, including when ports are partially occupied. ProTip: You can occupy a specific address withpython3 -m http.server --bind ::1 9999IPv4 (or127.0.0.1for IPv4). I've tested that when the preferred IPv4 address is occupied, the process gives an error. A warning is given when secondary addresses are occupied.Sample Commands