Using android/ios default ports #7149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
approved these changes
May 9, 2024
dconeybe
approved these changes
May 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7149 +/- ##
==========================================
- Coverage 54.10% 54.08% -0.03%
==========================================
Files 387 387
Lines 26094 26111 +17
Branches 5358 5360 +2
==========================================
+ Hits 14119 14121 +2
- Misses 10715 10730 +15
Partials 1260 1260 ☔ View full report in Codecov by Sentry. |
yuchenshi
reviewed
May 10, 2024
| @@ -13,7 +13,7 @@ export const DEFAULT_PORTS: { [s in Emulators]: number } = { | |||
| auth: 9099, | |||
| storage: 9199, | |||
| eventarc: 9299, | |||
| dataconnect: 9399, | |||
| dataconnect: 9509, | |||
There was a problem hiding this comment.
This changes the HTTP port, let's revert
GarrettBurroughs
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Using android/ios default ports * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Andorid and IOS default to 9510 - for now, lets hardcode grpc endpoint to that port. In the future, we should merge http and grpc to a single port.