Better null handling for extensions want

CHANGELOG.md

@@ -0,0 +1 @@
+- Fixed an issue where functions deployment would fail if `firebase.json#extensions` was undefined. (#7575)

src/deploy/extensions/planner.ts

@@ -84,7 +84,7 @@
   return i.extension;
 }
 
 /** Caching fetcher for the corresponding ExtensionSpec for an instance spec.
  */
 export async function getExtensionSpec(i: InstanceSpec): Promise<ExtensionSpec> {
   if (!i.extensionSpec) {
@@ -93,24 +93,24 @@
       i.extensionSpec = extensionVersion.spec;
     } else if (i.localPath) {
       i.extensionSpec = await readExtensionYaml(i.localPath);
       i.extensionSpec!.postinstallContent = await readPostinstall(i.localPath);
     } else {
       throw new FirebaseError("InstanceSpec had no ref or localPath, unable to get extensionSpec");
     }
   }
   return i.extensionSpec!;
 }
 
 /**
  * have checks a project for what extension instances are currently installed,
  * and returns them as a list of instanceSpecs.
  * @param projectId
  */
 export async function have(projectId: string): Promise<DeploymentInstanceSpec[]> {
   const instances = await extensionsApi.listInstances(projectId);
   return instances.map((i) => {
     const dep: DeploymentInstanceSpec = {
       instanceId: i.name.split("/").pop()!,
       params: i.config.params,
       systemParams: i.config.systemParams ?? {},
       allowedEventTypes: i.config.allowedEventTypes,
@@ -129,11 +129,11 @@
 /**
  * wantDynamic checks the user's code for Extension SDKs usage and returns
  * any extensions the user has defined that way.
  * @param args.projectId The project we are deploying to
  * @param args.projectNumber The project number we are deploying to.
- * @param args.extensions The extensions section of firebase.jsonm
+ * @param args.extensions The extensions section of firebase.json
  * @param args.emulatorMode Whether the output will be used by the Extensions emulator.
- *                     If true, this will check {instanceId}.env.local for params a
+ *                     If true, this will check {instanceId}.env.local for params
  */
 export async function wantDynamic(args: {
   projectId: string;
@@ -143,6 +143,9 @@
 }): Promise<DeploymentInstanceSpec[]> {
   const instanceSpecs: DeploymentInstanceSpec[] = [];
   const errors: FirebaseError[] = [];
+  if (!args.extensions) {
+    return [];
+  }
   for (const [instanceId, ext] of Object.entries(args.extensions)) {
     const autoPopulatedParams = await getFirebaseProjectParams(args.projectId, args.emulatorMode);
     const subbedParams = substituteParams(ext.params, autoPopulatedParams);
@@ -189,7 +192,7 @@
 /**
  * want checks firebase.json and the extensions directory for which extensions
  * the user wants installed on their project.
  * @param args.projectId The project we are deploying to
  * @param args.projectNumber The project number we are deploying to. Used for checking .env files.
  * @param args.aliases An array of aliases for the project we are deploying to. Used for checking .env files.
  * @param args.projectDir The directory containing firebase.json and extensions/
@@ -207,6 +210,9 @@
 }): Promise<DeploymentInstanceSpec[]> {
   const instanceSpecs: DeploymentInstanceSpec[] = [];
   const errors: FirebaseError[] = [];
+  if (!args.extensions) {
+    return [];
+  }
   for (const e of Object.entries(args.extensions)) {
     try {
       const instanceId = e[0];
@@ -257,7 +263,7 @@
           eventarcChannel: eventarcChannel,
         });
       }
     } catch (err: any) {
       logger.debug(`Got error reading extensions entry ${e}: ${err}`);
       errors.push(err as FirebaseError);
     }

src/deploy/extensions/prepare.ts

@@ -188,7 +188,7 @@ export async function prepareDynamicExtensions(
       projectNumber,
       aliases,
       projectDir,
-      extensions: options.config.get("extensions"),
+      extensions: options.config.get("extensions", {}),
     });
     noDeleteExtensions = noDeleteExtensions.concat(firebaseJsonWant);
     if (hasNonDeployingCodebases(options)) {
@@ -242,7 +242,7 @@ export async function prepare(context: Context, options: Options, payload: Paylo
     projectNumber,
     aliases,
     projectDir,
-    extensions: options.config.get("extensions"),
+    extensions: options.config.get("extensions", {}),
   });
   const dynamicWant = await planner.wantDynamic({
     projectId,