Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install unity in script and remove kuler90/setup-unity@v1 #539

Merged
merged 44 commits into from
Nov 29, 2022
Merged

Install unity in script and remove kuler90/setup-unity@v1 #539

merged 44 commits into from
Nov 29, 2022

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Nov 16, 2022 •
edited
Loading

Description

Removed kuler90/setup-unity@v1 dependency for unity installation.
Now, "Unity Hub download & installation", "Unity & Unity modules installation" processes are done by our script.

Also updated ReadMe and removed ruby dependency.

Testing

Packaging SDK workflow: https://github.com/firebase/firebase-unity-sdk/actions/runs/3492719189
Integration Test workflow: https://github.com/firebase/firebase-unity-sdk/actions/runs/3492874383

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@sunmou99
kuler90/build-unity
813fabb
@sunmou99
fix logging
01cb117
@sunmou99
test unity hub installation
30f0804
@sunmou99
test unity hub path
91abbea
@sunmou99
test unity hub path
3b0e421
@sunmou99
test unity hub path
4248790
@sunmou99
test unity hub path
bcfc9bd
@sunmou99
test unity hub path
e4e46d3
@sunmou99
test unity hub path
b1f1a8e
@sunmou99
test unity hub path
74038b7
@sunmou99
test unity hub mac
62d5a02
@sunmou99
test unity hub windows path
9763aea
@sunmou99
changeset
78cc1c5
@sunmou99
post installation for mac
e35ca15
@sunmou99
set installation path for windows
a097197
@sunmou99
set installation path for windows
09f5abc
@sunmou99
retry installation on failure
6f00707
@sunmou99
retry installation on failure
feee38f
@sunmou99
retry installation on failure
a98bc71
@sunmou99
test unity installation
a8c58df
@sunmou99
test unity installation
84c6658
@sunmou99
test unity installation
5039290
@sunmou99
test unity installation on mac
dad0e18
@sunmou99
test unity installation on linux
1d4cb7a
@sunmou99
add changeset
9966057
@sunmou99
update quote
f17f509
@sunmou99
updat linux installation
83a47b2
@sunmou99
linux xvfb-run --auto-servernum
bfb084a
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Nov 17, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 17, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Nov 18, 2022
@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit c03c041
Last updated: Mon Nov 28 21:42 PST 2022
View integration test log & download artifacts

Failures Configs
database [TEST] [FAILURE] [2020] [1/2 Build OS(s): windows] [1/6 Platform(s): Android] [1/3 Test Device(s): android_target]
firestore [TEST] [ERROR] [2020] [1/2 Build OS(s): macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): ios_target]
messaging [TEST] [ERROR] [2020] [1/2 Build OS(s): macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): ios_target]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 18, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 18, 2022
@sunmou99 sunmou99 added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 22, 2022
@sunmou99 sunmou99 added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. tests-requested: quick Trigger a quick set of integration tests. labels Nov 22, 2022
@sunmou99 sunmou99 removed the tests-requested: quick Trigger a quick set of integration tests. label Nov 28, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Nov 28, 2022
@sunmou99 sunmou99 added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 29, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 29, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 29, 2022
@sunmou99 sunmou99 merged commit 8c53096 into main Nov 29, 2022
@sunmou99 sunmou99 deleted the install-unity branch November 29, 2022 17:33
@firebase firebase locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@a-maurice a-maurice Awaiting requested review from a-maurice

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunmou99 @cynthiajoan