Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies: 🔥 Firebase 9 and Firebaseui 6 #158

Merged
merged 5 commits into from
Nov 9, 2021
Merged

Update dependencies: 🔥 Firebase 9 and Firebaseui 6 #158

merged 5 commits into from
Nov 9, 2021

Conversation

shiiinji
Copy link
Contributor

@shiiinji shiiinji commented Sep 2, 2021

  • Update Firebase 9 and Firebaseui 0.600

#156

yurist38
yurist38 reviewed Sep 13, 2021
View reviewed changes
README.md Outdated

// Configure Firebase.
const config = {
apiKey: 'AIzaSyAeue-AsYu76MMQlTOM-KlbYBlusW9c1FM',
authDomain: 'myproject-1234.firebaseapp.com',
// ...
};
firebase.initializeApp(config);
const firebaseApp = initializeApp(firebaseConfig);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see where the firebaseConfig is coming from. I think you missed its import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated README.md.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@shiiinji shiiinji mentioned this pull request Sep 22, 2021
Merged
@webzep
Copy link

webzep commented Sep 24, 2021

Can we get this merged in and published to NPM. I'm sure it would be greatly appreciated by about 20 thousand people per week by the looks of NPM.

@memark
Copy link

memark commented Sep 30, 2021

@yurist38 @jhuleatt Could we merge this please?

@yurist38
Copy link

I can't actually, don't have permissions...

@webzep
Copy link

webzep commented Oct 1, 2021

@nicolasgarnier - looks like you've done most of the work on this repo. Is this something you have permission to do?

@codercatdev codercatdev mentioned this pull request Oct 6, 2021
Closed
@piyushpcegarg
Copy link

@nicolasgarnier - can you please merge this PR and publish to NPM if you have permission? Waiting v9 compatible firebaseui-web-react because already migrated my project to firebase v9.

@dsibinski
Copy link

dsibinski commented Oct 30, 2021 •
edited
Loading

Any news here? firebaseui-web already supports Firebase v9 since 2 days ago 🙂
However, firebaseui package is now in version 6.0.0, so I guess this would need to be updated in this PR?

@memark
Copy link

memark commented Nov 2, 2021

Hey Google, can we please get this moving?

@oven-one
Copy link

oven-one commented Nov 3, 2021

Merge pls - this will be a huge help for a lotta devs

@wonsuc
Copy link

wonsuc commented Nov 3, 2021

+1 for merging this and publishing to NPM.

@jbdaines jbdaines mentioned this pull request Nov 3, 2021
Closed
@jhuleatt jhuleatt self-assigned this Nov 3, 2021
@jdmeyer3
Copy link

jdmeyer3 commented Nov 3, 2021

@shiiinji could this PR use firebaseui v6.0.0 instead?

@cyrrill
Copy link

cyrrill commented Nov 4, 2021

Please merge :)

@camm73
Copy link

camm73 commented Nov 4, 2021

Would be super helpful if this could be merged soon 🙂

@shiiinji
Copy link
Contributor Author

shiiinji commented Nov 4, 2021

@jdmeyer3

Updated to firebaseui v6.0.0.

@jhuleatt
Copy link
Contributor

jhuleatt commented Nov 9, 2021

Hi @shiiinji, thanks for your PR! We really appreciate all the time and effort you put into it. Unfortunately, we can't yet update this library to get tree-shaking benefits because the base FirebaseUI library is not compatible with Firebase v9's modular syntax:

FirebaseUI is not compatible with the v9 modular SDK. The v9 compatibility layer (specifically, the app-compat and auth-compat packages) permits the usage of FirebaseUI alongside v9, but without the app size reduction and other benefits of the v9 SDK.

Since FirebaseUI v6 only works with the compatibility layer, the main change this library needs (besides updating the firebaseui dependency and firebase peer dependency in package.json) is adding /compat/ to the import paths in the example and readme per these instructions. I know that's not as convenient as being able to move to the modular SDK, but it's the best we've got until the base FirebaseUI libraryfully supports modular v9. As a small win, the compat version of the auth library in v9 is still smaller than v8, even though it isn't tree-shakeable.

Would you like to create a PR to upgrade to v9 compat? If you do, I'll make it a priority to review it and get it published. If not, I can make a PR.

Again, thank you so much for the time and effort you put into this.

For those interested in firebaseui-web's plans for the modular syntax, please follow this feature request in the firebaseui-web repo.

@shiiinji
Copy link
Contributor Author

shiiinji commented Nov 9, 2021

Hi @jhuleatt , great thanks to your replying. I appreciate to share required /compat/ way for this library.

I updated 237f136 to /compat/ way, could you review the update?

jamesdaniels
jamesdaniels requested changes Nov 9, 2021
View reviewed changes
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shiiinji, just a couple small things.

dist/package.json Outdated Show resolved Hide resolved
example/src/App.jsx Show resolved Hide resolved
dist/README.md Show resolved Hide resolved
dist/README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
dist/package.json Outdated Show resolved Hide resolved
@jhuleatt jhuleatt changed the title Update dependencies: 🔥 Firebase 9 and Firebaseui 0.600 Update dependencies: 🔥 Firebase 9 and Firebaseui 6 Nov 9, 2021
@shiiinji
Copy link
Contributor Author

shiiinji commented Nov 9, 2021

@jamesdaniels

Thanks to your review.
Updated the issues.

@jhuleatt
Copy link
Contributor

jhuleatt commented Nov 9, 2021 •
edited
Loading

Thanks again @shiiinji!

react-firebaseui version 6.0.0 is now available on npm!

@jhuleatt jhuleatt merged commit f44e8d9 into firebase:master Nov 9, 2021
@jhuleatt jhuleatt mentioned this pull request Nov 9, 2021
Closed
@dpfundt
Copy link

dpfundt commented Nov 9, 2021

Awesome work @shiiinji!

@jhuleatt jhuleatt linked an issue Nov 16, 2021 that may be closed by this pull request
Add new version for testing v9 #154
Closed
@jhuleatt jhuleatt mentioned this pull request Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurist38 yurist38 yurist38 approved these changes

@SteeleRBG SteeleRBG SteeleRBG approved these changes

@jhuleatt jhuleatt jhuleatt approved these changes

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

Assignees

@jhuleatt jhuleatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new version for testing v9