Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fdc): Initial Release of Data Connect #13313

Merged
merged 4 commits into from
Sep 17, 2024
Merged

feat(fdc): Initial Release of Data Connect #13313

merged 4 commits into from
Sep 17, 2024

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Sep 11, 2024

This PR aims at adding Firebase Data Connect.

Checklist before merging:

maneesht and others added 3 commits September 11, 2024 10:29
* First pass at dataconnect

* Got mutations to work

* Finished WIP

* Used generated SDK

* Removed unrelated chagnes

* Cleanup

* Updated deps

* Addressed comments

* Removed prints

* Removed unnecessary protos

* Removed user class

* Removed unnecessary class

* Removed unnecessary deps

* Added back config files

* Fixed formatting

* added index.html

* Added license files

* Fixed formatting

* Fixed linting issues

* Fixed formatting

* Added protobuf as dependency

* Added license

* Ignored example dir for secret checking

* Added changelog and readme

* Updated package version

* Implemented app check

* Removed key

* Revert "Removed key"

This reverts commit 6a643f1.

* Removed key again

* Added error catching implementation (#13163)

* feat(dataconnect): Added error handling (#13175)

* Added missing file
* Removed unnecessary changes

* Miscellaneous cleanup

* Removed macros experiment

* Removed .then statements

* Removed debug prints

* Addressed first pass of comments

* Added movie_insert gql file

* Added comments

* Renamed package

* Another package rename

* Removed common package

* Added missing files

* Updated readme

* Revert "Removed common package"

This reverts commit 422bd80.

* Various improvements

* Made changes per api proposal

* Fixed initialization issues with generated SDK

* Made changes according to api council review

* Addressed Comments.

Removed references to personal firebase projects
Moved mapped host logic to new firebase_common package

* Added missing license header to files

* /s/query/operation

* API Council Changes

* Included list movies changes

* API council updates

* Addressed comments

* Removed print

* Added license header

* Removed files that should be gitignored

* Removed requirement on firebase_options

* Added missing line

* Removed windows and linux folders, updated changelog and gitignore

* Updated version of firebase_data_connect
* First pass at dataconnect

* Got mutations to work

* Finished WIP

* Used generated SDK

* Removed unrelated chagnes

* Cleanup

* Updated deps

* Addressed comments

* Removed prints

* Removed unnecessary protos

* Removed user class

* Removed unnecessary class

* Removed unnecessary deps

* Added back config files

* Fixed formatting

* added index.html

* Added license files

* Fixed formatting

* Fixed linting issues

* Fixed formatting

* Added protobuf as dependency

* Added license

* Ignored example dir for secret checking

* Added changelog and readme

* Updated package version

* Implemented app check

* Removed key

* Revert "Removed key"

This reverts commit 6a643f1.

* Removed key again

* Added error catching implementation (#13163)

* feat(dataconnect): Added error handling (#13175)

* Added missing file
* Removed unnecessary changes

* Miscellaneous cleanup

* Removed macros experiment

* Removed .then statements

* Removed debug prints

* Addressed first pass of comments

* Added movie_insert gql file

* Added comments

* Renamed package

* Another package rename

* Removed common package

* Added missing files

* Updated readme

* Revert "Removed common package"

This reverts commit 422bd80.

* Various improvements

* Made changes per api proposal

* Fixed initialization issues with generated SDK

* Made changes according to api council review

* Addressed Comments.

Removed references to personal firebase projects
Moved mapped host logic to new firebase_common package

* Added missing license header to files

* /s/query/operation

* API Council Changes

* Included list movies changes

* API council updates

* Addressed comments

* Removed print

* Added license header

* Removed files that should be gitignored

* Removed requirement on firebase_options

* Added missing line

* Removed windows and linux folders, updated changelog and gitignore

* Updated version of firebase_data_connect

* test(fdc): add e2e tests to the FDC package

* add e2e tests to CI

* test generated content

* update

* test

* add postgres

* more generation tests

* update podfile

* fix analyze

* regenerate with latest version

* add more queries

* add more queries?

* removing not generated commands

* more unit tests

* timestamp

* licence

* analyze

* add dev dep

* update generated

* ignore generated for licence

* add .firebaserc for dataconnect setup

* fix ci

* fix setup

* test

* more testing

* improve

* unset PGSERVICE

* mote testing

* okay?

* maybe this?

* update pubignore

* update

* ??

* hop

* more

* hophophop

* more

* web

* tests

* test

* merge clean

* regenerate

* fix

* fix

* more tests

* remove GoogleInfo Plist

* fix options

* test

* fix emulator

* clear text

* wut?

* fix generated code

* public level

* fix

* fix generated

* test

* maybe

* alors peut etre

* tests done

* update caching

* e2e tests

* tests done

* fix

* fix concurrency

* fixes

* fix

* again

* tests update

* test

---------

Co-authored-by: Maneesh Tewani <mtewani@google.com>
Co-authored-by: Maneesh Tewani <maneesht@users.noreply.github.com>
@Lyokone Lyokone changed the title feat(fdc): Initial Release of Data Connect (#13063) feat(fdc): Initial Release of Data Connect Sep 12, 2024
@russellwheatley russellwheatley marked this pull request as ready for review September 17, 2024 08:55
@russellwheatley russellwheatley merged commit 603a672 into main Sep 17, 2024
27 of 29 checks passed
@russellwheatley russellwheatley deleted the dataconnect branch September 17, 2024 11:03
@firebase firebase locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants