Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: shorten lines over 80 characters #13493

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

natebosch
Copy link
Contributor

@natebosch natebosch commented Oct 10, 2024

Reflow comments and break long strings into adjacent string literals.

Reflow comments and break long strings into adjacent string literals.
@natebosch natebosch requested a review from cynthiajoan October 10, 2024 18:25
@natebosch natebosch changed the title long lines Shorten lines over 80 characters Oct 10, 2024
@natebosch natebosch changed the base branch from main to vertexai/prepare_ga October 10, 2024 18:26
@natebosch natebosch changed the title Shorten lines over 80 characters style: shorten lines over 80 characters Oct 10, 2024
@cynthiajoan cynthiajoan merged commit ca5a63e into firebase:vertexai/prepare_ga Oct 11, 2024
16 of 30 checks passed
cynthiajoan added a commit that referenced this pull request Oct 18, 2024
…) and can be used in production apps. (#13453)

* chore(vertexai): fork vertexai sdk away from generative ai sdk. (#13298)

* fix the sdk name and support platform

* forking off model and chat class

* fork api class

* remove some export content since the next vertexai release will be breaking change.

* fork function calling

* fork off content

* fix for analyzer

* more analyzer fix

* chore(vertexai): Add corresponding unit test for the fork (#13324)

* Add corresponding unit test for the fork

* fix issues from analyzer

* feat(vertexai): add json schema support and update schema structure (#13378)

* Add schema support for prompt response

* update schema object, replace requiredProperties to optionalProperties

* api updates (breaking)

* more tweak during api review

* Add format for Schema.string

* fix test files

* Update packages/firebase_vertexai/firebase_vertexai/lib/src/vertex_api.dart

Co-authored-by: Nate Bosch <nbosch@google.com>

* add review feedback

---------

Co-authored-by: Nate Bosch <nbosch@google.com>

* feat(vertexai): update function calling and sample (#13395)

* Add schema support for prompt response

* update schema object, replace requiredProperties to optionalProperties

* api updates (breaking)

* more tweak during api review

* Add format for Schema.string

* fix test files

* first sample update

* remove embedding

* api update for function calling

* Update sample code to match the new api

* more code snippet for toolconfig

* apply documentation update

* tweak of the tools

* remove embed related class

* Update packages/firebase_vertexai/firebase_vertexai/example/lib/main.dart

Co-authored-by: Nate Bosch <nbosch@google.com>

* Update packages/firebase_vertexai/firebase_vertexai/example/lib/main.dart

Co-authored-by: Nate Bosch <nbosch@google.com>

* address review comments

* more fix

* keep name consistency

* keep using getWeather to keep align with devsite documentation

* Update the static name

---------

Co-authored-by: Nate Bosch <nbosch@google.com>

* feat(vertexai): update enums and citation and DataPart (#13410)

* Update SafeRating

* Rename citation source

* add blocked for SafetyRating parse

* Rename DataPart to InlineDataPart

* Update readme

* apply review comment

* feat(vertexai): Error message for service api not enabled. (#13435)

* Error message for service api not enabled.

* add quota exceed test

* Apply suggestions from code review

Co-authored-by: Nate Bosch <nbosch@google.com>

* Update for review comments

---------

Co-authored-by: Nate Bosch <nbosch@google.com>

* chore(vertexai): remove vertex_ file name for most of files (#13439)

* remove vertex_ file name for most of files

* organize import

* fix the optional attributes while parsing SafetyRating (#13452)

* chore(vertexai): function calling sample update (#13492)

* fix the optional attributes while parsing SafetyRating

* add doc comments

* update function sample

* comments

* Shorten lines over 80 columns (#13493)

Reflow comments and break long strings into adjacent string literals.

---------

Co-authored-by: Nate Bosch <nbosch@google.com>
@firebase firebase locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants