Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core, ios): ensure iOS SDK version can be found from Package.swift #13804

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 7, 2024

Description

Screenshot 2024-11-07 at 10 57 36

Related Issues

fixes #13726

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@kuhnroyal
Copy link

Tested this locally with Git dependency, no more build errors. Thanks!

@russellwheatley russellwheatley merged commit 83f4dad into main Nov 7, 2024
29 of 31 checks passed
@russellwheatley russellwheatley deleted the core-13726 branch November 7, 2024 14:52
@firebase firebase locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_core]: SPM usage fails to find firebase_sdk_version.rb
4 participants