Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust Toolchain to 1.76.0 #4457

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Feb 16, 2024

Some dependencies have recently adopted a MSRV of 1.74.0, which is higher than our current toolchain version (1.73.0). Update to the newest toolchain currently available, to unblock #4445

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@roypat roypat force-pushed the toolchain-1.76.0 branch 2 times, most recently from 7651ff5 to 855cda4 Compare February 16, 2024 16:32
@roypat roypat changed the title Toolchain 1.76.0 Update Rust Toolchain to 1.76.0 Feb 16, 2024
@roypat roypat marked this pull request as ready for review February 16, 2024 17:25
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bb8831) 81.56% compared to head (cd14a0e) 81.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4457      +/-   ##
==========================================
+ Coverage   81.56%   81.63%   +0.06%     
==========================================
  Files         243      243              
  Lines       29542    29800     +258     
==========================================
+ Hits        24095    24326     +231     
- Misses       5447     5474      +27     
Flag Coverage Δ
4.14-c5n.metal 78.95% <100.00%> (+0.08%) ⬆️
4.14-c7g.metal ?
4.14-m5d.metal ?
4.14-m5n.metal 78.93% <100.00%> (+0.08%) ⬆️
4.14-m6a.metal 78.08% <100.00%> (+0.09%) ⬆️
4.14-m6g.metal 77.03% <100.00%> (+0.07%) ⬆️
4.14-m6i.metal 78.93% <100.00%> (+0.08%) ⬆️
4.14-m7g.metal 77.03% <100.00%> (+0.07%) ⬆️
5.10-c5n.metal 81.60% <100.00%> (+0.07%) ⬆️
5.10-c7g.metal ?
5.10-m5d.metal ?
5.10-m5n.metal 81.59% <100.00%> (+0.07%) ⬆️
5.10-m6a.metal 80.82% <100.00%> (+0.08%) ⬆️
5.10-m6g.metal 79.91% <100.00%> (+0.06%) ⬆️
5.10-m6i.metal 81.58% <100.00%> (+0.07%) ⬆️
5.10-m7g.metal 79.91% <100.00%> (+0.06%) ⬆️
6.1-c5n.metal 81.60% <100.00%> (+0.07%) ⬆️
6.1-c7g.metal ?
6.1-m5d.metal ?
6.1-m5n.metal 81.59% <100.00%> (+0.07%) ⬆️
6.1-m6a.metal 80.82% <100.00%> (+0.08%) ⬆️
6.1-m6g.metal 79.91% <100.00%> (+0.06%) ⬆️
6.1-m6i.metal 81.58% <100.00%> (+0.07%) ⬆️
6.1-m7g.metal 79.91% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zulinx86
zulinx86 previously approved these changes Feb 19, 2024
Copy link
Contributor

@zulinx86 zulinx86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we create a pending PR to unpin Kani not to forget to do it?

@zulinx86
Copy link
Contributor

zulinx86 commented Feb 20, 2024

Sorry @roypat . My change adding --locked option caused a merge conflict :( Could you please rebase this PR on the latest main?

Some dependencies bumped their MSRV to 1.74.0, so lets move to the
newest toolchain.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Kani 0.46.0 seems to have a bug in its contract verification feature
that makes the gcd harness fail [1].

[1]: https://buildkite.com/firecracker/firecracker-pr/builds/9135

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
fix various new lints introduces since rust 1.73.0

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
v71 has the updated toolchain

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat
Copy link
Contributor Author

roypat commented Feb 20, 2024

LGTM! Should we create a pending PR to unpin Kani not to forget to do it?

opened an issue to the kani team: model-checking/kani#3035

@roypat roypat merged commit fa6c137 into firecracker-microvm:main Feb 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants