-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rust Toolchain to 1.76.0 #4457
Conversation
7651ff5
to
855cda4
Compare
b2efaae
to
87e9f24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4457 +/- ##
==========================================
+ Coverage 81.56% 81.63% +0.06%
==========================================
Files 243 243
Lines 29542 29800 +258
==========================================
+ Hits 24095 24326 +231
- Misses 5447 5474 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
87e9f24
to
406dc6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Should we create a pending PR to unpin Kani not to forget to do it?
Sorry @roypat . My change adding |
Some dependencies bumped their MSRV to 1.74.0, so lets move to the newest toolchain. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Kani 0.46.0 seems to have a bug in its contract verification feature that makes the gcd harness fail [1]. [1]: https://buildkite.com/firecracker/firecracker-pr/builds/9135 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
fix various new lints introduces since rust 1.73.0 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
v71 has the updated toolchain Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
a8a5b4a
to
cd14a0e
Compare
opened an issue to the kani team: model-checking/kani#3035 |
Some dependencies have recently adopted a MSRV of 1.74.0, which is higher than our current toolchain version (1.73.0). Update to the newest toolchain currently available, to unblock #4445
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
PR.
CHANGELOG.md
.TODO
s link to an issue.contribution quality standards.
rust-vmm
.