Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream fixes #196

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Upstream fixes #196

merged 3 commits into from
Jul 16, 2024

Conversation

JHopeCollins
Copy link
Collaborator

@JHopeCollins JHopeCollins commented Jul 3, 2024 •
edited
Loading

  1. flake8 complained about a missing space after comma that was previously fine.
  2. PETSc.Options.get* methods now require the default argument to be the correct type.
  3. No longer require an appctx for calling _break_function_space without passing an appctx dictionary (this one wasn't causing failures, it's just removing an unnecessary restriction).

@JHopeCollins JHopeCollins added bug Something isn't working upstream Issue related to upstream dependencies labels Jul 3, 2024
@JHopeCollins JHopeCollins self-assigned this Jul 3, 2024
@JHopeCollins JHopeCollins merged commit fd86815 into master Jul 16, 2024
1 check passed
@JHopeCollins JHopeCollins deleted the upstream_fixes branch July 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinjcotter colinjcotter colinjcotter approved these changes

Assignees

@JHopeCollins JHopeCollins

Labels
bug Something isn't working upstream Issue related to upstream dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JHopeCollins @colinjcotter