Olender/kmv to mlt rename #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple name change that needs to land with firedrakeproject/ufl#36 and firedrakeproject/tsfc#295.
This PR was made just to rename the KMV elements. KMV is a bit of a misnomer, since the last name of the first author of the cited paper is actually Chin-Joe-Kong (https://link.springer.com/article/10.1023/A:1004420829610).
Also, since this type of higher order triangular mass lumped triangular elements for the wave equation has been the subject of many papers getting the name of every researcher involved would be quite a list, therefore, I propose we just follow the nomenclature from the articles the used quadrature points come from and call them MLT.
Associated Pull Requests: