Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllAtOnceReducedFunctional - initial time-parallel implementation #3870

Draft
wants to merge 21 commits into
base: allatoncereducedfunctional
Choose a base branch
from

Conversation

JHopeCollins
Copy link
Contributor

@JHopeCollins JHopeCollins commented Nov 18, 2024

To merge into #3592

Parallelism implementation:

  • observation stages distributed over ensemble
  • context manager for recording the forward model and passing data between stages
  • iterator to record each stage and set the observation

Context manager+iterator for taping each stage:
https://github.com/firedrakeproject/4DVardrake/blob/2417d7cdff4a0a159ae8dcc9e12fb90d2382a67c/burgers/aaorf_4dvar_parallel.py#L250

connorjward and others added 14 commits November 5, 2024 07:58
* Add adjoint variational solver.
---------

Co-authored-by: Aaron Baier-Reinio <baierreinio@maths.ox.ac.uk>
* Simplify fwi test when run under CI
* Fix progress bar erros for parallel executions

* Test for a parallel execution
* Add petsc_raises fixture to catch PETSc callback exceptions
* Fix assembly of Real matrices
* Refactor test_demos, avoid mpiexec invocation
* Fix multigrid test, __main__ is not valid when importing
* Get value_shape from FunctionSpace

* Define FunctionSpace.block_size as the number of dofs per node

* sort_domains

---------

Co-authored-by: ksagiyam <k.sagiyama@imperial.ac.uk>
   - observation stages distributed over ensemble
   - context manager for recording the forward model and passing data between stages
   - iterator to record each stage and set the observation
@JHopeCollins JHopeCollins self-assigned this Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex0 ran0 passed0 skipped0 failed

@connorjward
Copy link
Contributor

@JHopeCollins FYI I broke one of the runners today. Hence the failure. I will try and fix it tomorrow.

Copy link

github-actions bot commented Nov 18, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real0 ran0 passed0 skipped0 failed

@JHopeCollins
Copy link
Contributor Author

@JHopeCollins FYI I broke one of the runners today. Hence the failure. I will try and fix it tomorrow.

No problem. I think I also need to merge main to update the versions of some of the stuff in CI.

JHopeCollins and others added 7 commits November 19, 2024 15:59
* DO NOT MERGE

* Test VOM with point variant

* Update .github/workflows/build.yml

* Test Regge point variant

* add continuity test

* Test H(curl div) element (#3843)

* Test H(curl div) element

* test Hu-Zhang

* checkout ufl master branch

* checkout master branches
@@ -83,6 +83,7 @@ jobs:
--install defcon \
--install gadopt \
--install asQ \
--package-branch pyadjoint JHopeCollins/set_working_tape_decorator \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--package-branch pyadjoint JHopeCollins/set_working_tape_decorator \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

6 participants