Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to some recovery related issues #548

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Fixes to some recovery related issues #548

merged 6 commits into from
Sep 11, 2024

Conversation

tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Aug 28, 2024 •
edited
Loading

This fixes some issues related to the recovery operators and wrappers:

  • allow the wrapper apply decorator to be used with implicit time discretisations
  • tweak the boundary method code in the RecoverySpaces object
  • enforcing the boundary conditions in the back-projection step in wrappers, which I found to be necessary to get the diffusion looking correct in the degree 0 Straka bubble

@tommbendall tommbendall added bug Pull requests or issues to relating to something not working enhancement Pull requests or issues relating to adding a new capability labels Aug 28, 2024
@tommbendall tommbendall mentioned this pull request Aug 28, 2024
Open
5 tasks
@tommbendall tommbendall marked this pull request as ready for review August 29, 2024 07:37
jshipton
jshipton approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@jshipton jshipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks @tommbendall !

@jshipton jshipton merged commit 6eebf46 into main Sep 11, 2024
4 checks passed
@jshipton jshipton deleted the TBendall/BackwardEulerWrapper branch September 11, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshipton jshipton jshipton approved these changes

Assignees
No one assigned
Labels
bug Pull requests or issues to relating to something not working enhancement Pull requests or issues relating to adding a new capability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommbendall @jshipton