Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting and linting via pre-commit hooks #99

Merged
merged 4 commits into from
Oct 29, 2023

Conversation

zStupan
Copy link
Collaborator

@zStupan zStupan commented Oct 29, 2023

  • Removed support for python 3.8, now only supporting >=3.9, <3.13
  • Updated dependencies.
  • Added pre-commit hooks for formatting and linting using the black formatter and the ruff linter. Using the default config for now.
  • Fixed an error in the hill_slopes function caused by the matplotlib update.
  • Updated the documentation
  • Reformatted the code.
  • Closes Add ruff #98

We can also add https://pre-commit.ci/ to the project, so that formatting and linting can be run in pull requests.

Copy link
Owner

@firefly-cpp firefly-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@firefly-cpp firefly-cpp merged commit 08fc804 into firefly-cpp:main Oct 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ruff
2 participants