Clean up Support for 32Bit Arduino Due #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2x255 bytes is to much for the uno
| @@ -489,7 +489,7 @@ void FirmataClass::sendStringf(const FlashString* flashString, int sizeOfArgs, . | |||
| { | |||
| // The parameter "sizeOfArgs" is currently unused. | |||
| // 16 bit board? | |||
| #if UINT_MAX <= UINT16_MAX | |||
| #ifdef ARDUINO_ARCH_AVR | |||
There was a problem hiding this comment.
Are you sure you want to limit this just to AVR architectures?
There was a problem hiding this comment.
No, I actually want to limit it to all architectures with only a "small" amount of RAM, but I didn't really find a good way of detecting that. There doesn't seem to be a way that for instance tells whether a CPU is 8 bit. I may need to add something like that to boards.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.