Add sequence Id for I2C #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrawehr
force-pushed
the
I2CMessageSequencing
branch
from
f3140d2
to
33caa76
Compare
This prevents mismatching the reply with the command, now required due to a but in the ESP32 firmware that adds an 1 second timeout to failed I2C requests.
pgrawehr
force-pushed
the
I2CMessageSequencing
branch
from
33caa76
to
6fbef51
Compare
Exceeds maximum size on the Arduino Uno otherwise
pgrawehr
force-pushed
the
I2CMessageSequencing
branch
from
6fbef51
to
cf7f025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See firmata/protocol#135 for the rationale to do this.