Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ESP32 PWM handling #135

Merged
merged 6 commits into from
Dec 26, 2022
Merged

Clean up ESP32 PWM handling #135

merged 6 commits into from
Dec 26, 2022

Commits on Dec 24, 2022

  1. Clean up ESP32 PWM handling 

    - Use of 13 bit resolution causes some unexpected behavior
- Simplify build dependencies
    @pgrawehr
    pgrawehr committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    e90d245 View commit details
    Browse the repository at this point in the history

  2. Ensure PWM pins are only setup once

    @pgrawehr
    pgrawehr committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    22b1ca2 View commit details
    Browse the repository at this point in the history

  3. Simplify handling of PWM 

    This currently disables fast PWM messages
    @pgrawehr
    pgrawehr committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    38c76d5 View commit details
    Browse the repository at this point in the history

  4. Use ledcWrite instead of analogWrite for consistency

    @pgrawehr
    pgrawehr committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    38422ba View commit details
    Browse the repository at this point in the history

  5. Remove debug messages

    @pgrawehr
    pgrawehr committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    66224ea View commit details
    Browse the repository at this point in the history

  6. Support short analog out message again 

    Repacking it as sysex message doesn't need
special callbacks
    @pgrawehr
    pgrawehr committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    dce4fa4 View commit details
    Browse the repository at this point in the history