review comments applied

firoorg · May 9, 2024 · c1d2b5c · c1d2b5c
1 parent 6c2c868
commit c1d2b5c
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/rpc/misc.cpp b/src/rpc/misc.cpp
@@ -1459,17 +1459,12 @@ UniValue checkifmncollateral(const JSONRPCRequest& request)
     CTransactionRef tx;
     uint256 hashBlock;
     if(!GetTransaction(txid, tx, Params().GetConsensus(), hashBlock, true))
-        throw std::runtime_error("Unable to get the transction");
+        throw std::runtime_error("Unknown transaction.");
 
     auto mnList = deterministicMNManager->GetListAtChainTip();
     COutPoint o(txid, index);
-
-    bool mnexists = false;
-    if (deterministicMNManager->IsProTxWithCollateral(tx, index) || mnList.HasMNByCollateral(o)) {
-        mnexists = true;
-    }
-
-    return UniValue(mnexists);
+    bool fMnExists = deterministicMNManager->IsProTxWithCollateral(tx, index) || mnList.HasMNByCollateral(o);
+    return UniValue(fMnExists);
 }
 
 UniValue getaddresstxids(const JSONRPCRequest& request)