Improving the listtransactions performance

firoorg · Apr 19, 2021 · f651249 · f651249
1 parent d76b2c5
commit f651249
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 12 deletions.
diff --git a/src/evo/deterministicmns.cpp b/src/evo/deterministicmns.cpp
@@ -993,7 +993,7 @@ bool CDeterministicMNManager::IsDIP3Enforced(int nHeight)
 
 void CDeterministicMNManager::CleanupCache(int nHeight)
 {
-    LOCK(cs);
+    AssertLockHeld(cs);
 
     std::vector<uint256> toDelete;
     for (const auto& p : mnListsCache) {

diff --git a/src/evo/deterministicmns.h b/src/evo/deterministicmns.h
@@ -664,7 +664,7 @@ class CDeterministicMNManager
     void UpgradeDBIfNeeded();
     static bool IsDIP3Active(int height);
 
-public:
+private:
     void CleanupCache(int nHeight);
 };
 

diff --git a/src/masternode-payments.cpp b/src/masternode-payments.cpp
@@ -247,14 +247,6 @@ bool CMasternodePayments::GetBlockTxOuts(int nBlockHeight, CAmount blockReward,
     return true;
 }
 
-bool CMasternodePayments::GetBlockTxOutsWipeCache(int nBlockHeight, CAmount blockReward, std::vector<CTxOut>& voutMasternodePaymentsRet) const
-{
-    bool result = GetBlockTxOuts(nBlockHeight, blockReward, voutMasternodePaymentsRet);
-    AssertLockHeld(cs_main);
-    deterministicMNManager->CleanupCache(chainActive.Height());
-    return result;
-}
-
 // Is this masternode scheduled to get paid soon?
 // -- Only look ahead up to 8 blocks to allow for propagation of the latest 2 blocks of votes
 bool CMasternodePayments::IsScheduled(const CDeterministicMNCPtr& dmnIn, int nNotBlockHeight) const

diff --git a/src/masternode-payments.h b/src/masternode-payments.h
@@ -32,7 +32,6 @@ class CMasternodePayments
 {
 public:
     bool GetBlockTxOuts(int nBlockHeight, CAmount blockReward, std::vector<CTxOut>& voutMasternodePaymentsRet) const;
-    bool GetBlockTxOutsWipeCache(int nBlockHeight, CAmount blockReward, std::vector<CTxOut>& voutMasternodePaymentsRet) const;
     bool IsTransactionValid(const CTransaction& txNew, int nBlockHeight, CAmount blockReward) const;
     bool IsScheduled(const CDeterministicMNCPtr& dmn, int nNotBlockHeight) const;
 

diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -1555,7 +1555,7 @@ void ListTransactions(CWallet * const pwallet, const CWalletTx& wtx, const strin
                     bool its_znode_payment = false;
                     if (!fSkipMnpayoutCheck) {
                         std::vector<CTxOut> voutMasternodePaymentsRet;
-                        mnpayments.GetBlockTxOutsWipeCache(txHeight, CAmount(), voutMasternodePaymentsRet);
+                        mnpayments.GetBlockTxOuts(txHeight, CAmount(), voutMasternodePaymentsRet);
                         //compare address of payee to addr.
                         for(CTxOut const & out : voutMasternodePaymentsRet) {
                             CTxDestination payeeDest;