Lelantus improvements #1012
Lelantus improvements #1012
Conversation
|
This pull request introduces 3 alerts when merging a4bf27b into b39fa5f - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 7a9372b into b39fa5f - view on LGTM.com new alerts:
|
…r in place of classic pointer
…in separators, add pubkeys into transcript
levonpetrosyan93
force-pushed
the
lelantus-improvements
branch
from
7a9372b
to
b2bfb13
Compare
|
This pull request introduces 3 alerts when merging b2bfb13 into b39fa5f - view on LGTM.com new alerts:
|
| @@ -27,6 +28,8 @@ struct NthPower { | |||
|
|
|||
| void go_next() { | |||
| pow *= num; | |||
| if (pow == Scalar(uint64_t(1))) | |||
| throw std::invalid_argument("NthPower resulted 1"); | |||
There was a problem hiding this comment.
I think this has DoS potential because NthPower is used in muptiple places and not only with challenge value. I.e. attacker can set some value in proof to 1 and if the exception is not properly caught it'll crash all the nodes. It's better to move the check to higher level.
There was a problem hiding this comment.
I have put this call in try-catch in verifier side. I think that is enoygh for preventing such risks.
There was a problem hiding this comment.
will doublecheck to verify that I did not missed it somewhere.
|
This pull request introduces 3 alerts when merging 86cdb95 into b39fa5f - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 532fe71 into b39fa5f - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 905dee5 into b39fa5f - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 0e6190e into b39fa5f - view on LGTM.com new alerts:
|
No description provided.