Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bip47 lelantus #1013

Merged
merged 181 commits into from
Jun 9, 2021
Merged
Show file tree
Hide file tree
Changes from 178 commits
Commits
Show all changes
181 commits
Select commit Hold shift + click to select a range
9c9b047
Add bip47
Dec 17, 2019
ed1ad93
Merge branch 'master' into feature/rap
top1st Dec 20, 2019
23eeddb
Update walletdb.cpp
top1st Dec 20, 2019
ec3a8b3
Update wallet.h
top1st Dec 20, 2019
291dc36
Fix Permissions Issue
Dec 20, 2019
c4e4d10
Add Space to Trigger Jenkins
HysMagus Dec 26, 2019
787042b
Remove Comments #1
HysMagus Jan 8, 2020
df5ae1e
Remove Extraneous Comments from Recent Payments
HysMagus Jan 8, 2020
61de989
Remove Comments from BIP47 Util
HysMagus Jan 8, 2020
09ed530
Remove Extraneous Comments
HysMagus Jan 8, 2020
33ed23f
Remove Extraneous Comments from the Channel File
HysMagus Jan 8, 2020
9a73197
Remove Extraneous Comments from Payment Code Page
HysMagus Jan 8, 2020
4d57355
Remove Extraneous Comments in Walletmodel
HysMagus Jan 8, 2020
b37f7a5
Remove Extra Comments
HysMagus Jan 8, 2020
ac7821b
Remove Extra Comments Related to Old PK Material
HysMagus Jan 8, 2020
6f6e9aa
Update addressbookpage.cpp
HysMagus Jan 8, 2020
c7dc81b
Remove Commented Code and Add Comment
HysMagus Jan 9, 2020
93b6a7b
Comment Intentionally Empty if Statement
HysMagus Jan 9, 2020
31c297b
Suppress False Flags and Remove Commented Code
HysMagus Jan 9, 2020
2447334
Remove Comments
HysMagus Jan 9, 2020
170657d
Remove Comments and Surpress False Alarms in Wallet and QT Folder
HysMagus Jan 13, 2020
7664a4a
Remove Comments and LGTM Alerts
HysMagus Jan 13, 2020
5da48dd
Porting Bip47 to Core14
levonpetrosyan93 Jan 27, 2020
dab422d
remove unused codes
top1st Jan 29, 2020
1223523
A little polishing
levonpetrosyan93 Feb 9, 2020
866a804
remove unused code
pvc2104 Feb 12, 2020
d3bdc7c
fix error in extracting designated public key in P2PK script
pvc2104 Feb 13, 2020
d22179e
remove unused function importBip47PaymentChannelData
pvc2104 Feb 13, 2020
564e66a
fix bugs in address book
pvc2104 Feb 14, 2020
4cf2852
disable delete/edit/new on payment code book
pvc2104 Feb 17, 2020
080c606
Bip47 changes merged
levonpetrosyan93 Feb 29, 2020
75c2480
Merge branch 'core14' into core14_bip47
levonpetrosyan93 Apr 13, 2020
20508d6
Merge branch 'core14' into core14_bip47
levonpetrosyan93 Apr 13, 2020
8b4e188
Fixing linking issues
levonpetrosyan93 Apr 14, 2020
8f72038
Merging core14 changes
levonpetrosyan93 May 21, 2020
db73678
Fixing build
levonpetrosyan93 Jun 1, 2020
90e4b79
Start BIP47 code refactor
riordant Jun 16, 2020
1876563
Class renaming; removing bad code
riordant Jun 16, 2020
e517a06
refactorings
pvc2104 Jun 30, 2020
55ea98f
Merge branch 'master' into bip47-refactor-cam
pvc2104 Sep 6, 2020
904bdcd
merge
pvc2104 Sep 6, 2020
a30f2c7
modify rpc commands
pvc2104 Sep 6, 2020
5007bf7
qt bip47 receive screen
pvc2104 Sep 9, 2020
8d56e4e
Merge QT
pvc2104 Oct 25, 2020
eea8210
Merged with master
Oct 26, 2020
3da69f3
Making tests work
Oct 27, 2020
c276e43
Making tests working
Oct 27, 2020
49424a8
Minor refactoring, fixing test crashes
Nov 2, 2020
e1e9124
Added the namespace
Nov 4, 2020
1336bf8
Classes were renamed to compy with the convention
Nov 4, 2020
db467fc
Minor optimization
Nov 4, 2020
6a3f729
Minor refactoring
Nov 5, 2020
fb0d049
First test done
Nov 5, 2020
fa7ecf6
Minor cleanup
Nov 5, 2020
92ff97f
Ecdh params tests are done
Nov 7, 2020
e5ce0c4
Done the shared secret test
Nov 10, 2020
8979116
CPaymentAddress, CPaymentChannel refactoring
Nov 13, 2020
a2d2b26
Address generation based on shared secret is done
Nov 16, 2020
4359fe6
Masked payload has been done
Nov 18, 2020
c2f0dae
Merged with master
Nov 20, 2020
ee08407
Minor merge error
Nov 20, 2020
813615e
Merge cleanup and minor improvements
Nov 20, 2020
c58e923
Redesing of bip47 wallet and account has been started
Nov 27, 2020
27b4704
Account functionality has been split
Dec 3, 2020
19f6e4d
Change in comments
Dec 3, 2020
2579bf1
Sending account has been done
Dec 8, 2020
ab4991f
Implemented payment code unmasking
Dec 9, 2020
7b1f5a2
Preparation for address similarity tests
Dec 10, 2020
83270f0
Addresses made the same using DH on both sides
Dec 11, 2020
9235904
Cleaning up the previous implementation
Dec 14, 2020
0aa89cd
Secret addresses in the wallet. Preparatory steps
Dec 15, 2020
0a97063
Secret addresses added to the wallet.
Dec 18, 2020
49b72b6
Minor improvement for pcode validation
Dec 21, 2020
ceb1cc3
Minor improvement for address generation
Dec 21, 2020
3249d06
Preparation for a notification TX sending
Dec 23, 2020
2b86965
Preparing of a notification tx has been done
Dec 23, 2020
8511306
Receiving of notification txs is done
Dec 29, 2020
05cd646
Minor improvements
Dec 29, 2020
245c259
A basic RPC test has been done
Dec 29, 2020
960389f
Minor redesign in account numbering
a-bezrukov Jan 27, 2021
83b8cac
Merged with master
a-bezrukov Feb 2, 2021
bde687a
Merge remote-tracking branch 'origin/master' into bip47_wip
a-bezrukov Feb 5, 2021
5ea7648
WIP making notification TX use Lelantus
a-bezrukov Feb 12, 2021
9eb5f0f
Notification tx use Lelantus was done
a-bezrukov Feb 16, 2021
eaaf266
Dealing with prelim code review
a-bezrukov Feb 17, 2021
bef8f0f
Merge remote-tracking branch 'origin' into bip47_wip
a-bezrukov Feb 17, 2021
063d285
Test for Lelantus use
a-bezrukov Feb 17, 2021
2248443
Serialization work was commenced
a-bezrukov Feb 19, 2021
0d368cb
Payment channel serialization tests
a-bezrukov Feb 19, 2021
05981d5
Serialization tests for accounts were done
a-bezrukov Feb 25, 2021
4aa19cc
Serialization and unit tests added
a-bezrukov Feb 26, 2021
140c754
Secret privkeys were revised
a-bezrukov Feb 26, 2021
3970485
Secret privkeys were revised.Minor addition
a-bezrukov Mar 1, 2021
e7ae3b5
Serialization is almost done and tested
a-bezrukov Mar 3, 2021
4906ad9
Lelantus fixes
levonpetrosyan93 Mar 4, 2021
3bf0eac
Reverted the initial code
a-bezrukov Mar 4, 2021
24e72bc
Added the RAP form
a-bezrukov Mar 4, 2021
9157222
Minor improvements
a-bezrukov Mar 4, 2021
dedd066
Fixing Range proof challenge generation
levonpetrosyan93 Mar 8, 2021
a6e0f33
GUI: Creation of pcodes is done
a-bezrukov Mar 8, 2021
f342c69
Add new challenge generator with CHash256 and use it for new version
levonpetrosyan93 Mar 8, 2021
eedab79
Linking transcripts betweed sigma and balance proofs, using unique_pt…
levonpetrosyan93 Mar 9, 2021
abb276e
GUI: Started implementing Sending to pcode
a-bezrukov Mar 9, 2021
bd02974
GUI: Sending to pcode dialog was designed
a-bezrukov Mar 9, 2021
da60231
GUI: Sending funds to pcode GUI has almost been done.
a-bezrukov Mar 11, 2021
bc0c907
GUI: Sending funds to pcode GUI has been done.
a-bezrukov Mar 11, 2021
bf49e0f
Not using std::any
a-bezrukov Mar 11, 2021
6db1fc3
Use jsplit version instead of comparing height, add version into doma…
levonpetrosyan93 Mar 12, 2021
7ad5722
Opted out from use size_t in address numbering
a-bezrukov Mar 12, 2021
7a5b4b7
Minor fixes
levonpetrosyan93 Mar 15, 2021
7f2bc23
Adding some comments
levonpetrosyan93 Mar 15, 2021
e3d1882
Minor refactoring and bugfixes, Some advanced features are implemented
a-bezrukov Mar 17, 2021
1948f8c
Minor fix for test memory leaks
a-bezrukov Mar 19, 2021
83ec272
Removing unneeded functions from SigmaExtendedProver/Verifier
levonpetrosyan93 Mar 19, 2021
8ac3b97
Review comments applied
levonpetrosyan93 Mar 20, 2021
20710c2
Adding schnorr proof for Qk
levonpetrosyan93 Mar 20, 2021
aa9b83a
Added check to verify that n-th power is not returning 1
levonpetrosyan93 Mar 22, 2021
aca0aa9
Use template and merge 2 challenge generator classes
levonpetrosyan93 Mar 23, 2021
a2fa2ad
Review comment applied
levonpetrosyan93 Mar 23, 2021
19dd0f0
Minor display improvements
a-bezrukov Mar 24, 2021
fcc2960
Showing advanced address information
a-bezrukov Mar 24, 2021
e4565eb
Allowing bip47 to be null
a-bezrukov Mar 24, 2021
db88595
Version bump, testnet HF block, testnet blacklist
levonpetrosyan93 Mar 24, 2021
65e7965
Minor improvements, autotests
a-bezrukov Mar 25, 2021
e0ed28c
QT warnings have been fixed
a-bezrukov Mar 26, 2021
6cc2246
Handling Sigma selection for bip47
a-bezrukov Mar 27, 2021
453cda4
Fixing a minor bug
levonpetrosyan93 Mar 29, 2021
52e6a23
Version 0.14.6.0
a-bezrukov Mar 29, 2021
d90ef39
Gui improvements, bugfixes
a-bezrukov Mar 29, 2021
6454643
Index loading fixed
levonpetrosyan93 Mar 30, 2021
5003d7b
Saving set hash only if there are mints in the block
levonpetrosyan93 Mar 30, 2021
9e9fd54
Failing test fixed
levonpetrosyan93 Mar 30, 2021
d261a94
Fixing db reading error
levonpetrosyan93 Mar 30, 2021
a4bf27b
Changing HF block for mainnnet
levonpetrosyan93 Apr 2, 2021
903883e
Fixing the rescan issues
a-bezrukov Apr 2, 2021
52eb7e3
Merged with Lelantus
a-bezrukov Apr 2, 2021
5cb47cf
Setting mainnet HF block
levonpetrosyan93 Apr 5, 2021
7a9372b
Check unique-properties of ProUpRegTx when building new list
levonpetrosyan93 Apr 5, 2021
ebbc1bf
Unlock dialog was added
a-bezrukov Apr 5, 2021
7d70f7d
Merge branch 'lelantus-improvements' into bip47_lelantus
a-bezrukov Apr 5, 2021
9bdca0b
Tests have been fixed
a-bezrukov Apr 9, 2021
75469c4
Resolved conflicts with the parent branch
a-bezrukov Apr 13, 2021
11028d9
Fixing the lelantus discrepancies
a-bezrukov Apr 13, 2021
849e4b3
Merge remote-tracking branch 'origin/lelantus-improvements' into bip4…
a-bezrukov Apr 13, 2021
17bbcfa
Code style fix
a-bezrukov Apr 14, 2021
74695c3
Starting the encrypted wallet fix
a-bezrukov Apr 20, 2021
1245f44
The encrypted wallet fix
a-bezrukov Apr 21, 2021
f380f38
Fix for Unlock close crash, cannot send when unconfirmed
a-bezrukov Apr 26, 2021
7aa3eb1
Merge with master
a-bezrukov Apr 26, 2021
f03911d
Version v0.14.7.0
a-bezrukov Apr 26, 2021
89cbbaf
More conflicts resolved
a-bezrukov Apr 26, 2021
d4f5b3c
Improving tests stability
a-bezrukov Apr 27, 2021
805fe9d
Adding the Reconsider bip47 transaction menu item
a-bezrukov Apr 28, 2021
9b5c8d1
Transaction description was improved
a-bezrukov Apr 29, 2021
38e1019
Dealing with lgtm comments
a-bezrukov Apr 29, 2021
1d23391
Making the filenames unique
a-bezrukov May 5, 2021
d309751
Making the filenames unique
a-bezrukov May 5, 2021
ec9533a
Merge branch 'master' into bip47_lelantus
a-bezrukov May 17, 2021
9585036
Adding Pcodes to the address book
a-bezrukov May 21, 2021
9081049
Fixing the code review comments
a-bezrukov May 24, 2021
f855674
BIP47 pcodes addressbook
a-bezrukov May 26, 2021
1d23e11
BIP47 pcodes addressbook. Minor improvements
a-bezrukov May 26, 2021
69a1481
Improving the OP_RETURN data display
a-bezrukov May 26, 2021
8e289d6
Improving the tx long descriptiong
a-bezrukov May 27, 2021
461333e
Setting used address number was done
a-bezrukov May 30, 2021
3cf8870
Resolving Macos build issues
a-bezrukov May 30, 2021
abedcd4
Minor GUI: balance display, first time message
a-bezrukov May 31, 2021
53ead4d
GUI improvements: not showing secret address dialog after a notificat…
a-bezrukov May 31, 2021
8e36f81
GUI: unlock message was done
a-bezrukov May 31, 2021
9978151
GUI: Added hints to send pcode dialog
a-bezrukov May 31, 2021
aa1ca4f
GUI: wording change
a-bezrukov May 31, 2021
282d10b
GUI: wording change
a-bezrukov May 31, 2021
c50f119
Fixing macos build
a-bezrukov May 31, 2021
47626f6
GUI: Transaction page now supports pcodes
a-bezrukov Jun 1, 2021
ecfcbf4
Fixing typo and uninitialized value
a-bezrukov Jun 2, 2021
72e15e7
GUI: minor fixes and improvements
a-bezrukov Jun 2, 2021
cc72c32
GUI: typo fixes
a-bezrukov Jun 2, 2021
952262a
GUI: minor size fixes
a-bezrukov Jun 2, 2021
698fb7c
Locking the notification tx output
a-bezrukov Jun 8, 2021
67a5377
Dealing with code review comments
a-bezrukov Jun 9, 2021
cc5d57f
Dealing with code review comments
a-bezrukov Jun 9, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ dnl require autoconf 2.60 (AS_ECHO/AS_ECHO_N)
AC_PREREQ([2.60])
define(_CLIENT_VERSION_MAJOR, 0)
define(_CLIENT_VERSION_MINOR, 14)
define(_CLIENT_VERSION_REVISION, 6)
define(_CLIENT_VERSION_BUILD, 1)
define(_CLIENT_VERSION_REVISION, 7)
define(_CLIENT_VERSION_BUILD, 0)
define(_CLIENT_VERSION_IS_RELEASE, true)
define(_COPYRIGHT_YEAR, 2021)
define(_COPYRIGHT_HOLDERS,[The %s developers])
Expand Down
1 change: 1 addition & 0 deletions contrib/bitcoin-qt.pro
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ FORMS += \
../src/qt/forms/openuridialog.ui \
../src/qt/forms/optionsdialog.ui \
../src/qt/forms/overviewpage.ui \
../src/qt/forms/paymentcodepage.ui \
../src/qt/forms/receivecoinsdialog.ui \
../src/qt/forms/receiverequestdialog.ui \
../src/qt/forms/debugwindow.ui \
Expand Down
4 changes: 4 additions & 0 deletions qa/pull-tester/rpc-tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,10 @@

# Unstable tests
#, 'dip4-coinbasemerkleroots.py'

# bip47
'bip47-sendreceive.py',
'bip47-walletrestore.py'
]
# if ENABLE_ZMQ:
# testScripts.append('zmq_test.py')
Expand Down
60 changes: 60 additions & 0 deletions qa/rpc-tests/bip47-sendreceive.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
#!/usr/bin/env python3
# Copyright (c) 2017-2021 The Firo Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
"""dip47 sending receiving RPCs QA test.
"""

from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import *

class Bip47SendReceive(BitcoinTestFramework):

def __init__(self):
super().__init__()
self.setup_clean_chain = True
self.num_nodes = 3

def setup_network(self, split=False):
self.nodes = start_nodes(self.num_nodes, self.options.tmpdir)
connect_nodes_bi(self.nodes,0,1)
connect_nodes_bi(self.nodes,1,2)
connect_nodes_bi(self.nodes,0,2)
self.is_network_split=False
self.sync_all()

def run_test(self):

self.nodes[1].generate(1010)
node0_pcode = self.nodes[0].createpcode("node0-pcode0")

try:
self.nodes[1].setupchannel(node0_pcode)
raise AssertionError('Lelantus balance should be zero')
except JSONRPCException as e:
assert(e.error['code']==-6)

self.nodes[1].mintlelantus(1)
self.nodes[1].mintlelantus(1)
self.nodes[1].generate(10)
self.nodes[1].setupchannel(node0_pcode)
self.nodes[1].generate(1)
sync_blocks(self.nodes)
self.nodes[1].sendtopcode(node0_pcode, 10)

self.nodes[1].generate(1)
self.sync_all()

assert_equal(self.nodes[0].getbalance(), Decimal("10.0001"))

self.nodes[0].sendtoaddress(self.nodes[2].getaccountaddress(""), 10)

self.sync_all()
self.nodes[1].generate(1)
sync_blocks(self.nodes)

assert_equal(self.nodes[2].getbalance(), Decimal("10"))


if __name__ == '__main__':
Bip47SendReceive().main()
40 changes: 40 additions & 0 deletions qa/rpc-tests/bip47-walletrestore.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
#!/usr/bin/env python3
# Copyright (c) 2017-2021 The Firo Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
"""dip47 sending receiving RPCs QA test.
"""

from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import *

class Bip47WalletRestore(BitcoinTestFramework):

def __init__(self):
super().__init__()
self.setup_clean_chain = True
self.num_nodes = 1

def setup_network(self, split=False):
self.nodes = start_nodes(self.num_nodes, self.options.tmpdir)

def run_test(self):
backup_file = os.path.join(self.options.tmpdir, "cleanwallet.bak")
wallet_file = os.path.join(self.options.tmpdir, "node0/regtest/wallet.dat")
self.nodes[0].backupwallet(backup_file)
initial_pcodes = [self.nodes[0].createpcode("pcode" + str(num)) for num in range(0,200)]
assert(len(initial_pcodes) == 200)

stop_node(self.nodes[0], 0)
os.remove(wallet_file)
shutil.copy(backup_file, wallet_file)

self.nodes[0] = start_node(0, self.options.tmpdir)
assert(len(self.nodes[0].listpcodes()) == 0)

for i in range(0, 200):
assert(initial_pcodes[i] == self.nodes[0].createpcode("pcode" + str(i)))


if __name__ == '__main__':
Bip47WalletRestore().main()
2 changes: 1 addition & 1 deletion qa/rpc-tests/llmq-cl-evospork.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def wait_for_chainlock_tip(self, node):

def wait_for_chainlock(self, node, block_hash):
t = time()
while time() - t < 15:
while time() - t < 30:
try:
block = node.getblock(block_hash)
if block["confirmations"] > 0 and block["chainlock"]:
Expand Down
11 changes: 11 additions & 0 deletions src/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,12 @@ BITCOIN_CORE_H = \
hdmint/mintpool.h \
hdmint/tracker.h \
hdmint/wallet.h \
bip47/defs.h \
bip47/account.h \
bip47/paymentchannel.h \
bip47/bip47utils.h \
bip47/paymentcode.h \
bip47/secretpoint.h \
sigma.h \
lelantus.h \
blacklists.h \
Expand Down Expand Up @@ -495,6 +501,11 @@ libbitcoin_wallet_a_SOURCES = \
wallet/authhelper.cpp \
hdmint/tracker.cpp \
policy/rbf.cpp \
bip47/account.cpp \
bip47/paymentchannel.cpp \
bip47/bip47utils.cpp \
bip47/paymentcode.cpp \
bip47/secretpoint.cpp \
primitives/mint_spend.cpp \
$(BITCOIN_CORE_H)

Expand Down
18 changes: 15 additions & 3 deletions src/Makefile.qt.include
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ QT_FORMS_UI = \
qt/forms/debugwindow.ui \
qt/forms/sendcoinsdialog.ui \
qt/forms/sendcoinsentry.ui \
qt/forms/sendtopcodedialog.ui \
qt/forms/signverifymessagedialog.ui \
qt/forms/transactiondescdialog.ui \
qt/forms/sendmpdialog.ui \
Expand All @@ -130,7 +131,8 @@ QT_FORMS_UI = \
qt/forms/metadexdialog.ui \
qt/forms/tradehistorydialog.ui \
qt/forms/elyassetsdialog.ui \
qt/forms/lelantusdialog.ui
qt/forms/lelantusdialog.ui \
qt/forms/createpcodedialog.ui

QT_MOC_CPP = \
qt/moc_addressbookpage.cpp \
Expand All @@ -150,6 +152,7 @@ QT_MOC_CPP = \
qt/moc_manualmintdialog.cpp \
qt/moc_coincontroltreewidget.cpp \
qt/moc_csvmodelwriter.cpp \
qt/moc_createpcodedialog.cpp \
qt/moc_editaddressdialog.cpp \
qt/moc_guiutil.cpp \
qt/moc_intro.cpp \
Expand All @@ -174,6 +177,7 @@ QT_MOC_CPP = \
qt/moc_rpcconsole.cpp \
qt/moc_sendcoinsdialog.cpp \
qt/moc_sendcoinsentry.cpp \
qt/moc_sendtopcodedialog.cpp \
qt/moc_signverifymessagedialog.cpp \
qt/moc_splashscreen.cpp \
qt/moc_trafficgraphwidget.cpp \
Expand All @@ -199,7 +203,8 @@ QT_MOC_CPP = \
qt/moc_lelantusdialog.cpp \
qt/moc_lelantuscoincontroldialog.cpp \
qt/moc_automintmodel.cpp \
qt/moc_automintnotification.cpp
qt/moc_automintnotification.cpp \
qt/moc_pcodemodel.cpp

BITCOIN_MM = \
qt/macdockiconhandler.mm \
Expand Down Expand Up @@ -236,6 +241,7 @@ BITCOIN_QT_H = \
qt/bitcoinunits.h \
qt/clientmodel.h \
qt/coincontroldialog.h \
qt/createpcodedialog.h \
qt/manualmintdialog.h \
qt/coincontroltreewidget.h \
qt/csvmodelwriter.h \
Expand All @@ -257,6 +263,7 @@ BITCOIN_QT_H = \
qt/overviewpage.h \
qt/paymentrequestplus.h \
qt/paymentserver.h \
qt/pcodemodel.h \
qt/peertablemodel.h \
qt/platformstyle.h \
qt/qvalidatedlineedit.h \
Expand All @@ -267,6 +274,7 @@ BITCOIN_QT_H = \
qt/rpcconsole.h \
qt/sendcoinsdialog.h \
qt/sendcoinsentry.h \
qt/sendtopcodedialog.h \
qt/signverifymessagedialog.h \
qt/splashscreen.h \
qt/trafficgraphwidget.h \
Expand Down Expand Up @@ -309,6 +317,7 @@ RES_ICONS = \
qt/res/icons/firo.png \
qt/res/icons/zerocoin.png \
qt/res/icons/sigma.png \
qt/res/icons/paymentcode.png \
qt/res/icons/masternodes.png \
qt/res/icons/qrcode.png \
qt/res/icons/chevron.png \
Expand Down Expand Up @@ -417,18 +426,21 @@ BITCOIN_QT_WALLET_CPP = \
qt/addresstablemodel.cpp \
qt/askpassphrasedialog.cpp \
qt/coincontroldialog.cpp \
qt/manualmintdialog.cpp \
qt/coincontroltreewidget.cpp \
qt/createpcodedialog.cpp \
qt/editaddressdialog.cpp \
qt/manualmintdialog.cpp \
qt/openuridialog.cpp \
qt/overviewpage.cpp \
qt/pcodemodel.cpp \
qt/paymentrequestplus.cpp \
qt/paymentserver.cpp \
qt/receivecoinsdialog.cpp \
qt/receiverequestdialog.cpp \
qt/recentrequeststablemodel.cpp \
qt/sendcoinsdialog.cpp \
qt/sendcoinsentry.cpp \
qt/sendtopcodedialog.cpp \
qt/signverifymessagedialog.cpp \
qt/transactiondesc.cpp \
qt/transactiondescdialog.cpp \
Expand Down
3 changes: 3 additions & 0 deletions src/Makefile.test.include
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ BITCOIN_TESTS = \
test/base58_tests.cpp \
test/base64_tests.cpp \
test/bip32_tests.cpp \
test/bip47_test_data.h \
test/bip47_tests.cpp \
test/bip47_serialization_tests.cpp \
test/blockencodings_tests.cpp \
test/bloom_tests.cpp \
test/bswap_tests.cpp \
Expand Down
4 changes: 2 additions & 2 deletions src/base58.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ std::string EncodeBase58Check(const std::vector<unsigned char>& vchIn);
* Decode a base58-encoded string (psz) that includes a checksum into a byte
* vector (vchRet), return true if decoding is successful
*/
inline bool DecodeBase58Check(const char* psz, std::vector<unsigned char>& vchRet);
bool DecodeBase58Check(const char* psz, std::vector<unsigned char>& vchRet);

/**
* Decode a base58-encoded string (str) that includes a checksum into a byte
* vector (vchRet), return true if decoding is successful
*/
inline bool DecodeBase58Check(const std::string& str, std::vector<unsigned char>& vchRet);
bool DecodeBase58Check(const std::string& str, std::vector<unsigned char>& vchRet);

/**
* Base class for all base58-encoded data
Expand Down
Loading