Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace part of balance verification with multiscalar multiplication operation #1037

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

AaronFeickert
Copy link
Contributor

Updates balance proof verification to use multiscalar multiplication operations where applicable.

Review requested.

@AaronFeickert AaronFeickert marked this pull request as ready for review May 24, 2021 15:57
Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is good, but I will suggest to leave computation of A as is, as previously it was doing Cout.size() times additions and one multiplication, but now it is doing several multiplications,
I tried to test, and in my setup I got this 716 for old version, 491 for your case, and 400 in case what I am suggesting, numbers are in clock ticks.

@AaronFeickert
Copy link
Contributor Author

The idea is good, but I will suggest to leave computation of A as is, as previously it was doing Cout.size() times additions and one multiplication, but now it is doing several multiplications,
I tried to test, and in my setup I got this 716 for old version, 491 for your case, and 400 in case what I am suggesting, numbers are in clock ticks.

Updated.

@AaronFeickert AaronFeickert changed the title Replace balance verification with multiscalar multiplication operations Replace part of balance verification with multiscalar multiplication operation Jun 21, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jun 21, 2021

This pull request introduces 2 alerts and fixes 2 when merging 3af6901 into 237d229 - view on LGTM.com

new alerts:

  • 2 for Unused static function

fixed alerts:

  • 2 for Unused static function

@reubenyap reubenyap added this to the v0.14.7.1 milestone Jun 22, 2021
@reubenyap reubenyap merged commit 892c64e into firoorg:master Jun 22, 2021
@AaronFeickert AaronFeickert deleted the schnorr-efficiency branch June 24, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants