Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AmountWithFeeExceedsBalance when sending Lelantus transaction #1042

Conversation

KuroGuo
Copy link
Contributor

@KuroGuo KuroGuo commented Jun 16, 2021

Show a more explicit message when the amount exceeds the balance without subtracting the transaction fee.

@KuroGuo KuroGuo force-pushed the handle-lelantus-amount-with-fee-exceeds-balance branch from 30aeb9a to fc6b651 Compare June 16, 2021 19:00
@KuroGuo KuroGuo force-pushed the handle-lelantus-amount-with-fee-exceeds-balance branch from fc6b651 to 6fd41c0 Compare June 16, 2021 19:06
@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2021

This pull request introduces 3 alerts when merging 6fd41c0 into 237d229 - view on LGTM.com

new alerts:

  • 3 for Unused static function

@reubenyap reubenyap added this to the v0.14.7.1 milestone Jun 22, 2021
@a-bezrukov a-bezrukov merged commit d5dcf7c into firoorg:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants