Batching fail fix #1048
Merged
Batching fail fix #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levonpetrosyan93
force-pushed
the
batching_fail_fix
branch
from
f4a4cba
to
7c9550a
Compare
psolstice
requested changes
Jul 9, 2021
src/batchproof_container.cpp
Outdated
| void BatchProofContainer::erase(std::vector<LelantusSigmaProofData>* vProofs, const Scalar& serial) { | ||
| for (auto dataItr = vProofs->begin(); dataItr != vProofs->end(); dataItr++) { | ||
| if (dataItr->serialNumber == serial) { | ||
| vProofs->erase(dataItr); |
There was a problem hiding this comment.
This will crash if serial is the last element of vProofs (dataItr will be past the end of vector). Also std::vector<T>::erase will invalidate iterators in some cases. I'd do it with std::remove_if.
There was a problem hiding this comment.
agree, done
psolstice
approved these changes
Jul 11, 2021
a-bezrukov
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes batch verification failing issue in case of reindex/sync, The fail was happening when you had reorgs in chain, During DisconnectBlock it should remove proofs from container, but it was not removed and verification failed as proof from wrong chain is not valid after reorg.
Removing was not being done correctly as third element in key, was being set as true, 7c9550a#diff-755c76a1b8be7607bc371ca3a5b4ea39a91bf46946913fd5fd67b4d06b808d7dR97 ,
but actually it should be false, but now in removeLelantus() function is being removed also sigmaToLelantus proofs.