Move Lelantus joinsplit data into DASH v3 payload #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levonpetrosyan93
previously approved these changes
Aug 17, 2021
psolstice
force-pushed
the
lelantus-payload
branch
from
bcef7d7
to
a650e53
Compare
psolstice
force-pushed
the
lelantus-payload
branch
from
a650e53
to
4a69aa5
Compare
levonpetrosyan93
approved these changes
Aug 17, 2021
psolstice
added a commit
that referenced
this pull request
Aug 17, 2021
reubenyap
pushed a commit
that referenced
this pull request
Aug 17, 2021
This was referenced Aug 18, 2021
This was referenced Aug 20, 2021
This was referenced Sep 26, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Hardware wallets (Trezor) may have problems with transaction input
scriptSigbeing too large. This is a workaround for this.Code changes brief
Lelantus joinsplit opcode
OP_LELANTUSJOINSPLITPAYLOADis introduced. With this opcodescriptSigis just one byte in size, actual payload is invExtraPayloadfield ofCTransaction