Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment for block numbers in consensus following faster blocks hardfork #1185

Merged
merged 5 commits into from
Jul 20, 2022

Conversation

psolstice
Copy link
Contributor

PR intention

After PR #1176 any planned change to the network based on block number will come sooner than before because blocks come faster now. This PR fixes this.

Code changes brief

Changes were made to the following consensus parameters:

  • height of the second halving
  • number of blocks between halvings starting from the second one
  • height of the block at which block has no subsidy anymore
  • number of block for spork functionality to stop

Also minimum peer version is set to 0.14.10

@lgtm-com
Copy link

lgtm-com bot commented Jun 27, 2022

This pull request fixes 2 alerts when merging 016fba3 into cb15a23 - view on LGTM.com

fixed alerts:

  • 2 for Unused static function

Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenyap reubenyap merged commit 21d5c65 into master Jul 20, 2022
@reubenyap reubenyap deleted the params-adjustment branch July 20, 2022 13:42
levonpetrosyan93 pushed a commit that referenced this pull request May 17, 2023
…dfork (#1185)

* Adjustment for consensus parameters following faster blocks hardfork

* Test for having a second and third halvings at correct block numbers

* Change minimum version of peer to 0.14.10.0

* Fixed subsidy_limit_test

* Fixed peer version parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants