Update binding hash function signature #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
binding-hash-header
branch
from
6b1f546
to
63035cd
Compare
AaronFeickert
force-pushed
the
binding-hash-header
branch
from
6a8a315
to
4740d98
Compare
psolstice
approved these changes
Jan 19, 2024
|
This shouldn't affect verification, but should be tested with a reindex to confirm. |
levonpetrosyan93
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Updates
SpendTransaction::hash_bind_innerto make it static and takeS1andTas arguments.Code changes brief
Previously, the function in question was not static, and inferred
S1andTfrom the object. This was inconsistent and had a bad code smell.This PR makes the function static and is explicit about all fields used in the hash.