Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug creating large spark spend tx #1399

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix bug creating large spark spend tx #1399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/spark/sparkwallet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,9 +1525,6 @@ CWalletTx CSparkWallet::CreateSparkSpendTransaction(
i++;
}

// check fee
wtxNew.SetTx(MakeTransactionRef(std::move(tx)));

if (GetTransactionWeight(tx) >= MAX_NEW_TX_WEIGHT) {
throw std::runtime_error(_("Transaction too large"));
}
Expand All @@ -1546,6 +1543,8 @@ CWalletTx CSparkWallet::CreateSparkSpendTransaction(
throw std::invalid_argument(_("Not enough fee estimated"));
}

wtxNew.SetTx(MakeTransactionRef(std::move(tx)));

result.push_back(wtxNew);
}
}
Expand Down
Loading