Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright ©️ in LicenseInfo ℹ️ #949

Merged
merged 4 commits into from
Jan 7, 2021

Conversation

KuroGuo
Copy link
Contributor

@KuroGuo KuroGuo commented Dec 19, 2020

There was a duplicate in the copyright ©️ information and the year didn't match, I updated it. 🍻

image

image

@KuroGuo KuroGuo changed the title Update copyright ©️ in LicenseInfo ℹ️ Update copyright ©️ in LicenseInfo ℹ️ Dec 19, 2020
@HysMagus
Copy link
Contributor

HysMagus commented Dec 19, 2020 via email

@KuroGuo
Copy link
Contributor Author

KuroGuo commented Dec 19, 2020

I don't think Dash should be listed because Dash is not Firo's dad 👴

@reubenyap
Copy link
Member

Dash should be included because of the usage of their masternode infrastructure work.
The double mention was probably due to a find/replace when porting over masternode code.

@KuroGuo
Copy link
Contributor Author

KuroGuo commented Dec 24, 2020

Added at the bottom.

This product includes Masternodes software developed by the Dash Core developers <https://www.dash.org>.

@HysMagus
Copy link
Contributor

utACK

@lgtm-com
Copy link

lgtm-com bot commented Jan 6, 2021

This pull request introduces 3 alerts when merging ab7363f into 0ffbbc4 - view on LGTM.com

new alerts:

  • 3 for Unused static function

@reubenyap reubenyap merged commit 456bbdd into firoorg:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants