Fix for "sendmany" RPC call insufficient funds message #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a simpler new implementation of getbalance logic along with asserts to confirm it behaves identically to the old logic. The old logic is removed in the next commit.
psolstice
changed the title
sendmany RPC call insufficient funds message
psolstice
changed the title
sendmany RPC call insufficient funds message
a-bezrukov
approved these changes
Feb 2, 2021
|
This pull request introduces 2 alerts when merging 51ec1a1 into 5bee49f - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Fix an issue with deprecated account system preventing
sendtomanyRPC call from working in some casesCode changes brief
Merged bitcoin PR #9614
bitcoin/bitcoin#9614
On top of this added a check for first parameter of
sendmany. Made changes to do not use account system while processing RPC if the first parameter is empty.