Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git submodules instead of having the ci add youtube-dl #37

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Use git submodules instead of having the ci add youtube-dl #37

merged 3 commits into from
Nov 10, 2021

Conversation

nullket
Copy link
Collaborator

@nullket nullket commented Nov 10, 2021

Currently youtube-dl is added during the package release within the ci.

This PR integrates youtube-dl (and youtube-dlp in prepartion to be used and integrated in a future PR) as submodules instead. The benefits are:

  • Version control on the release side (and tested in development before)
  • Your local plugin folder would (almost see below) resemble the release version
  • The github action would only had to remove the .git folder, add the version etc. (like it already does right now)
  • Adding or removing an alternate youtube-dl fork would be quite easy

Attention: @firsttris due to the github workflow using your kodi github repos (including tokens etc.) I was not able test the changes to the build-addon.yml and build-script.sh as well as the resulting addon zip file. But I did check the addon locally with the changes and the addon works perfectly (it still uses youtube-dl, the dlp fork is just already added to the lob folder)

nullket and others added 3 commits November 10, 2021 09:29
… the github action (which releases this addon). Instead the new git submodules are used. Following the recommendation in the kodi wiki, they are stored in a subfolder called lib. Also removed the travis instructions to clean up a bit
Make action checkout submodules as well
@nullket nullket mentioned this pull request Nov 10, 2021
@firsttris firsttris merged commit 65926be into firsttris:master Nov 10, 2021
@firsttris
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants