Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added js solution to _3 #188

Merged

Conversation

sambabib
Copy link
Contributor

I solved question 3 in javascript. Hopefully, it helps more javascript-centric devs. Also hope to do a lot more of these but here's my first submission. Thank you.

@sambabib
Copy link
Contributor Author

sambabib commented Oct 9, 2024

I have also added a backtracking javascript solution to question 17. Hopefully, this can help expand the javascript solution base.

Copy link
Owner

@fishercoder1534 fishercoder1534 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add links to these two solutions on the README.md as well: https://github.com/fishercoder1534/Leetcode/tree/master/paginated_contents/algorithms/1st_thousand

@sambabib
Copy link
Contributor Author

LGTM, can you add links to these two solutions on the README.md as well: https://github.com/fishercoder1534/Leetcode/tree/master/paginated_contents/algorithms/1st_thousand

I just added links to the README.md. At the moment, they point to my fork as the links do not currently exist on this repo. I can update them after the PR has been merged.

@sambabib
Copy link
Contributor Author

You can also let me know your preferred way of doing this. Thank you.

@fishercoder1534
Copy link
Owner

Add them to point the the master branch please, it'll existing once this PR is merged in, thanks!

@sambabib
Copy link
Contributor Author

Add them to point the the master branch please, it'll existing once this PR is merged in, thanks!

It's all done now. I have just updated the links to point to the master branch.

@sambabib
Copy link
Contributor Author

sambabib commented Nov 7, 2024

Quick reminder, the javascript links have been updated as requested.

@fishercoder1534 fishercoder1534 merged commit 2548c18 into fishercoder1534:master Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants