Skip to content

Use native-loading plug-in
Compare
Choose a tag to compare
@fredden fredden released this 09 May 10:46
· 2 commits to master since this release
2.4.0
a43cdbc
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode. 
Use native-loading plug-in (#13)

* Upgrade lazysizes to v5.3.2

* Work around bug in Magento's mixins.js

The `processNames` method doesn't cope with a null name, which is what happens
when a module correctly registers itself anonymously, using the Univeral Module
Definition pattern. This is needed as lazysizes plugins rely on RequireJS
working properly.

References:
https://github.com/magento/magento2/blob/2.4.2/lib/web/mage/requirejs/mixins.js#L191-L193
https://github.com/umdjs/umd/blob/v1.0.0/returnExportsGlobal.js#L19

* Use RequireJS dependency rather than global object

* Add native-loading plugin for lazysizes

* Enable native-loading plug-in

* Update templates for native-loading plug-in

* Update README with information for native-loading

* Correct whitespace per PHP_CodeSniffer complaints
Assets 2
Loading