Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sprite): reposition rope tiles in atlas for padding #1041

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

nelson137
Copy link
Contributor

Fixes #1014 (for now).

It sounds like a proper fix entails significant work; but to fix the immediate issue we can move the rope tiles away from any others so that those adjacent to them are blank.

Before

before-asset before-game

After

after-asset after-game

@MaxCWhitehead
Copy link
Collaborator

Yeah a rendering fix did not seem very clear, I think this is good, I had not tried this but good to know can be fixed in authoring of the tilesets.

Haven't had a chance to boot up game and double check - I see level 3 is updated. Do you happen to know if any other levels use these rope tiles or just 3?

If no other levels will go ahead and merge. Thanks!

@nelson137
Copy link
Contributor Author

Good catch, levels 7 & 8 also have ropes that were broken. Those are now fixed:

Level 7

Before After
level-7-before level-7-after

Level 8

Before After
level-8-before level-8-after

@nelson137
Copy link
Contributor Author

nelson137 commented Nov 9, 2024

Well I found a few more, the railing and flag in this atlas have the same issue.

EDIT: and the crow's nest

@MaxCWhitehead
Copy link
Collaborator

Well I found a few more, the railing and flag in this atlas have the same issue.

EDIT: and the crow's nest

Ah gotcha, those were much less noticeable to me. Good to know. Should I go ahead and merge this (we can open a new issue for those)? If want to update PR for anything I can leave it open.

@nelson137
Copy link
Contributor Author

Yeah I think this is good to merge as-is. I can do the others in a follow-up.

@MaxCWhitehead MaxCWhitehead added this pull request to the merge queue Nov 10, 2024
Merged via the queue into fishfolk:main with commit 62fb20c Nov 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering artifacts on edge of rope netting sprite
2 participants