Save selector dictionary and write out in manifest [#2693][#2800] #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
force-pushed
the
feature/2693-selectors-to-manifest
branch
from
d21fe83
to
a25a80b
Compare
gshank
force-pushed
the
feature/2693-selectors-to-manifest
branch
9 times, most recently
from
4947954
to
3a60345
Compare
jtcohen6
approved these changes
Nov 10, 2020
Comment on lines
+915
to
+921
| # Provide support for copy.deepcopy() - we just need to avoid the lock! | ||
| # pickle and deepcopy use this. It returns a callable object used to | ||
| # create the initial version of the object and a tuple of arguments | ||
| # for the object, i.e. the Manifest. | ||
| # The order of the arguments must match the order of the attributes | ||
| # in the Manifest class declaration, because they are used as | ||
| # positional arguments to construct a Manifest. |
gshank
force-pushed
the
feature/2693-selectors-to-manifest
branch
from
3a60345
to
74316bf
Compare
kwigley
approved these changes
Nov 10, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2693 and #2800
Description
Saves dictionary version of selectors.yml file and includes in the manifest, for use in docs generate later. Adds the ability to include a 'description' in a selector.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.