Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up docker resources #3019

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Clean up docker resources #3019

merged 3 commits into from
Jan 25, 2021

Conversation

kwigley
Copy link
Contributor

@kwigley kwigley commented Jan 20, 2021 •
edited
Loading

(partially) resolves dbt-labs/dbt-release#3

Description

  • rm older dockerfiles
  • add dockerfile from dbt-releases
  • rename the development dockerfile to Dockerfile.dev to avoid confusion

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

- rm older dockerfiles
b50bfa7 
- add dockerfile from dbt-releases
- rename the development dockerfile to Dockerfile.dev to avoid confusion
@cla-bot cla-bot bot added the cla:yes label Jan 20, 2021
@kwigley
Copy link
Contributor Author

kwigley commented Jan 20, 2021

Will merge into dev/margaret-mead after PR merge.

@kwigley kwigley mentioned this pull request Jan 20, 2021
Closed
@kwigley kwigley self-assigned this Jan 20, 2021
jtcohen6
jtcohen6 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think this will clear up confusion around Docker <> version support for folks just looking at the repo.

@jtcohen6
Copy link
Contributor

Will merge into dev/margaret-mead after PR merge.

We'll need to merge into / rebase dev/margaret-mead against dev/kiyoshi-kuromiya after final v0.19.0 release, and again with dev/0.19.1 once we have a release candidate there. Lots of git fun ahead of us :)

@kwigley kwigley merged commit 540c1fd into dev/kiyoshi-kuromiya Jan 25, 2021
@kwigley kwigley deleted the fix/cleanup-dockerfile branch January 25, 2021 15:19
@jtcohen6 jtcohen6 mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@gshank gshank Awaiting requested review from gshank

Assignees

@kwigley kwigley

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwigley @jtcohen6