Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate command flag input by adding cli hook #1017

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Conversation

life1347
Copy link
Member

@life1347 life1347 commented Dec 5, 2018

Fix #1014

$ fission fn create name t4
Fatal error: No valid flags are provided. Please ensure flag name has "--" prefix.

$ fission fn create --name t4 --env nodejs \
  --code /github.com/fission/fission/examples/nodejs/* --minscale 0 --maxscale 4 \
  --executortype newdeploy sfdfhjdhkjsdf
Fatal error: Unable to parse flags: --code, --executortype
The argument should have only one input value. Please quote the input value if it contains wildcard characters(*).

This change is Reviewable

@life1347 life1347 added this to the 1.0-rc1 milestone Dec 7, 2018
@life1347 life1347 merged commit f0c0936 into master Dec 10, 2018
@life1347 life1347 deleted the validate-cli-input branch December 10, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate command flag input
1 participant