Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encoded path in router #1347

Merged
merged 4 commits into from
Oct 9, 2019
Merged

Support encoded path in router #1347

merged 4 commits into from
Oct 9, 2019

Conversation

life1347
Copy link
Member

@life1347 life1347 commented Oct 8, 2019

Encoded path means the URL path contains encoded string like "/foo%2Fbar".
Gorilla/Mux by default doesn't enable encoded path support, you need to enable
it when initializing the router.

This PR adds a new environment variable USE_ENCODED_PATH to router
deployment to enable encoded path support.

Fix #1317


This change is Reviewable

Encoded path means the URL path contains encoded string like "/foo%2Fbar".
Gorilla/Mux by default doesn't enable encoded path support, you need to enable
it when initializing the router.

This PR adds a new environment variable USE_ENCODED_PATH to router
deployment to enable encoded path support.
@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #1347 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1347      +/-   ##
=========================================
+ Coverage   27.39%   27.4%   +<.01%     
=========================================
  Files          70      70              
  Lines        7378    7383       +5     
=========================================
+ Hits         2021    2023       +2     
- Misses       5123    5124       +1     
- Partials      234     236       +2
Impacted Files Coverage Δ
pkg/router/router.go 14.7% <50%> (+1.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c8569...6bdefe9. Read the comment docs.

@life1347 life1347 merged commit 1075c5d into master Oct 9, 2019
@life1347 life1347 deleted the encoded-path branch October 9, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fission route URL param doesn't support encode string
1 participant