Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replaced context.TODO() with request.Context() in API files #2214

Merged
merged 2 commits into from
Oct 4, 2021
Merged

refactor: Replaced context.TODO() with request.Context() in API files #2214

merged 2 commits into from
Oct 4, 2021

Conversation

praddy26
Copy link
Member

@praddy26 praddy26 commented Oct 2, 2021

No description provided.

@praddy26 praddy26 changed the title Replaced context.TODO() with request.Context() in API files refactor: Replaced context.TODO() with request.Context() in API files Oct 2, 2021
sanketsudake
sanketsudake requested changes Oct 4, 2021
View reviewed changes
pkg/controller/api.go Outdated Show resolved Hide resolved
pkg/controller/functionApi.go Outdated Show resolved Hide resolved
pkg/controller/httpTriggerApi.go Outdated Show resolved Hide resolved
@sanketsudake sanketsudake merged commit 23f4643 into fission:master Oct 4, 2021
@sanketsudake
Copy link
Member

Thanks for finding it out and fixing it @praddy26 🎉

@praddy26 praddy26 deleted the todo-context-request branch October 4, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praddy26 @sanketsudake