Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min length restriction for name query #279

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

fityannugroho
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • ..... (describe the other type)

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

Since the pagination feature is available, the minimum character length restriction for name query is no longer necessary.

What is the new behavior?

  • Remove minimum character length for name query
  • Set maximum character length for name query to 100
  • Allow empty value for name query (?name= is valid now)

Other information

None

@fityannugroho fityannugroho added the enhancement New feature or request label Jan 18, 2024
@fityannugroho fityannugroho merged commit 5ad9fea into main Jan 18, 2024
5 checks passed
@fityannugroho fityannugroho deleted the name-query-update branch January 18, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant