Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: replace ESLint and Prettier with Biome #440

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

fityannugroho
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

  • Outdated ESLint configuration (Latest ESLint uses flat config)
  • Too many third-party packages needed to make ESLint work with Typescript and Prettier

What is the new behavior?

This pull request includes several changes focused on migrating from ESLint and Prettier to Biome for linting and formatting. The most important changes include the removal of ESLint and Prettier configurations, the addition of Biome configuration, and updates to the package.json to reflect these changes.

Migration to Biome:

  • .eslintrc.js: Removed the ESLint configuration file.
  • .prettierrc: Removed the Prettier configuration file.
  • biome.json: Added a new Biome configuration file with detailed settings for linting and formatting.

Updates to package.json:

  • package.json: Updated the lint and lint:fix scripts to use Biome instead of ESLint.
  • package.json: Added @biomejs/biome to devDependencies and removed ESLint and Prettier dependencies.

Minor formatting changes:

  • nest-cli.json: Reformatted the plugins array to a single line.
  • package.json: Reformatted the keywords array to a single line.

Other information

This PR makes almost no changes to any existing styling rules.

@fityannugroho fityannugroho added the dependencies Pull requests that update a dependency file label Oct 17, 2024
@fityannugroho fityannugroho merged commit 554297d into main Oct 17, 2024
11 checks passed
@fityannugroho fityannugroho deleted the refactor/use-biomejs branch October 17, 2024 16:08
@fityannugroho fityannugroho added the breaking changes Changes that will break the current app label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Changes that will break the current app dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant